From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Hetu Subject: Re: [PATCH] gnu: Add guile-gnome Date: Wed, 08 Jun 2016 13:34:00 -0400 Message-ID: <87y46fk2k7.fsf@auf.org> References: <1464375363-31718-1-git-send-email-patrick.hetu@auf.org> <87y46ui2uk.fsf@gnu.org> <87ziqwkhkw.fsf@auf.org> <87vb1jhl7w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAhMm-00078L-Oi for guix-devel@gnu.org; Wed, 08 Jun 2016 13:34:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAhMh-0004lz-6z for guix-devel@gnu.org; Wed, 08 Jun 2016 13:34:08 -0400 Received: from smtp.ca.auf.org ([199.84.140.5]:47094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAhMh-0004l4-1h for guix-devel@gnu.org; Wed, 08 Jun 2016 13:34:03 -0400 Received: from smtp-sortant.ca.auf.org (smtp-sortant.ca.auf.org [199.84.140.10]) by smtp.ca.auf.org (Postfix) with ESMTP id 6F78218E0 for ; Wed, 8 Jun 2016 13:34:01 -0400 (EDT) Received: from localhost (amavis-montreal.ca.auf.org [199.84.140.2]) by smtp-sortant.ca.auf.org (Postfix) with ESMTP id ABC3CB77B for ; Wed, 8 Jun 2016 13:34:01 -0400 (EDT) Received: from smtp-sortant.ca.auf.org ([199.84.140.10]) by localhost (amavis-montreal.ca.auf.org [199.84.140.2]) (amavisd-new, port 10024) with ESMTP id jIeXq7toAlFU for ; Wed, 8 Jun 2016 13:34:00 -0400 (EDT) Received: from sans-nom.auf.org (unknown [10.36.1.102]) by smtp-sortant.ca.auf.org (Postfix) with ESMTPSA id 8BF884D2 for ; Wed, 8 Jun 2016 13:34:00 -0400 (EDT) In-reply-to: <87vb1jhl7w.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s @ 2016-06-08 09:19 EDT: > Patr --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-g-wrap-Fix-installation-path.patch Content-Description: 0001-gnu-g-wrap-Fix-installation-path.patch >From 66baa02e5683a309588ae0a68a7d1b918ad72d8e Mon Sep 17 00:00:00 2001 From: Patrick Hetu Date: Wed, 8 Jun 2016 13:18:07 -0400 Subject: [PATCH] gnu: g-wrap: Fix installation path * gnu/packages/guile.scm (g-wrap): Add 2.0/ to the installation path --- gnu/packages/guile.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index 74e58c4..04c3f03 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -939,6 +939,16 @@ capabilities.") ("guile-lib" ,guile-lib))) (inputs `(("libffi" ,libffi))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'configure 'pre-configure + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* (find-files "." "^Makefile.in$") + (("guilemoduledir =.*guile/site" all) + (string-append all "/2.0"))) + #t)))))) (synopsis "Generate C bindings for Guile") (description "G-Wrap is a tool and Guile library for generating function wrappers for inter-language calls. It currently only supports generating Guile -- 2.7.4 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ick Hetu skribis: > >> Ludovic Court=C3=A8s @ 2016-05-28 12:06 EDT: >> >>> Pushed as 9b381643f009025d97dfc0b82d2c00800c204380 with a few minor >>> changes: >> [...] >> Still, the current g-wrap package needs a new patch to fix his Makefil= e.in >> because the native-search-paths hooks won't find it for Guile 2.0. > > But it works well to build guile-gnome AFAICS. When is it a problem? I'm getting this error in a simple test script: In ice-9/boot-9.scm: 2951: 3 [define-module* (gnome gw gtk) #:filename ...] 2926: 2 [resolve-imports ((#) (#) (#) (#) ...)] 2867: 1 [resolve-interface (g-wrap gw standard) #:select ...] In unknown file: ?: 0 [scm-error misc-error #f ...] ERROR: In procedure scm-error: ERROR: no code for module (g-wrap gw standard) because the g-wrap code is under: /gnu/store/...-g-wrap-1.9.15/share/guile/site /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap.scm /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap/compat.scm /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap/config.scm and not /gnu/..../share/guile/2.0/g-wrap/... > But yeah, patching it to match the native-search-paths is a good idea. ok, I've attached the patch. >> Also, should I rename it to guile-g-wrap at the same time? > > I don=E2=80=99t think so, because it=E2=80=99s both a program and a lib= rary, not just a > library (I see that this rule mine and is not spelled out in =E2=80=9CP= ackaging > Guidelines=E2=80=9D; it probably should, if there=E2=80=99s consensus.) ok. Patrick --=-=-=--