Re: [PATCH 1/2] gnu: Add nasm.

[ludo@gnu.org (Ludovic Courtès)]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

ludo@gnu.org (Ludovic Courtès) skribis:

> Jan Nieuwenhuizen <janneke@gnu.org> skribis:
>
>> From bfe40f5a42edf702277a2580336138438cdb8a62 Mon Sep 17 00:00:00 2001
>> From: Jan Nieuwenhuizen <janneke@gnu.org>
>> Date: Sat, 18 Jun 2016 22:39:33 +0200
>> Subject: [PATCH 1/2] gnu: Add nasm.
>>
>> * gnu/packages/nasm.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>
> Applied but to assembly.scm as Alex suggested; I also added a
> ‘supported-systems’ field.

I forgot to mention another thing: nasm is currently not
bit-reproducible, as visible with --rounds=2, due to differences in its
PDF and PS files:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2508 bytes --]

$ diff -ur /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01 /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01-check
Binary files /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01/doc/nasm/nasmdoc.pdf and /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01-check/doc/nasm/nasmdoc.pdf differ
diff -ur /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01/doc/nasm/nasmdoc.ps /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01-check/doc/nasm/nasmdoc.ps
--- /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01/doc/nasm/nasmdoc.ps	1970-01-01 01:00:01.000000000 +0100
+++ /gnu/store/0804r4rcm0gw8kdgf9dy9bhakn1xqdpl-nasm-2.12.01-check/doc/nasm/nasmdoc.ps	1970-01-01 01:00:01.000000000 +0100
@@ -3,30 +3,30 @@
 %%BoundingBox: 0 0 595 792
 %%Creator: (NASM psflow.pl)
 %%DocumentData: Clean7Bit
-%%DocumentFonts: Courier-Bold Times-Roman Courier Times-Italic Times-BoldItalic Times-Bold
-%%DocumentNeededFonts: Courier-Bold Times-Roman Courier Times-Italic Times-BoldItalic Times-Bold
+%%DocumentFonts: Courier-Bold Times-Roman Times-BoldItalic Times-Bold Times-Italic Courier
+%%DocumentNeededFonts: Courier-Bold Times-Roman Times-BoldItalic Times-Bold Times-Italic Courier
 %%Orientation: Portrait
 %%PageOrder: Ascend
 %%EndComments
 %%BeginProlog
-/bulladj 12 def
-/idxgutter 24 def
-/startcopyright 75 def
-/rmarg 50 def
-/idxcolumns 2 def
-/lmarg 100 def
-/topmarg 100 def
+/botmarg 100 def
 /tocpnz 24 def
-/tocdots 8 def
-/prmarg 0 def
+/idxcolumns 2 def
 /pagewidth 595 def
+/idxspace 24 def
 /plmarg 50 def
+/startcopyright 75 def
+/tocdots 8 def
+/topmarg 100 def
+/lmarg 100 def
+/pageheight 792 def
+/pymarg 50 def
 /idxindent 24 def
+/prmarg 0 def
+/rmarg 50 def
+/idxgutter 24 def
+/bulladj 12 def
 /tocind 12 def
-/pymarg 50 def
-/pageheight 792 def
-/idxspace 24 def
-/botmarg 100 def
 /colorlinks false def
 /NASMEncoding [ /.notdef  /.notdef  /.notdef  /.notdef  /.notdef  
  /.notdef  /.notdef  /.notdef  /.notdef  /.notdef  /.notdef  /.notdef  
@@ -70,10 +70,10 @@
 } def
 /Courier-Bold-NASM /Courier-Bold nasmenc
 /Times-Roman-NASM /Times-Roman nasmenc
-/Courier-NASM /Courier nasmenc
-/Times-Italic-NASM /Times-Italic nasmenc
 /Times-BoldItalic-NASM /Times-BoldItalic nasmenc
 /Times-Bold-NASM /Times-Bold nasmenc
+/Times-Italic-NASM /Times-Italic nasmenc
+/Courier-NASM /Courier nasmenc
 /tfont0 /Times-Bold-NASM findfont 20 scalefont def
 /tfont1 /Times-BoldItalic-NASM findfont 20 scalefont def
 /tfont2 /Courier-Bold-NASM findfont 20 scalefont def

[-- Attachment #3: Type: text/plain, Size: 237 bytes --]


Could you look into it?

I suspect it would be easier to simply remove these two files.  Packages
in Guix don’t usually install their PDF/PS documentation, and this one
already installs its doc as HTML.

TIA!  :-)

Ludo’.