From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] build: emacs: Search elisp files in "share/emacs/site-lisp". Date: Wed, 22 Jun 2016 11:16:32 +0300 Message-ID: <87y45xtz8f.fsf@gmail.com> References: <87d1ncatv8.fsf@gmail.com> <87mvme1gtw.fsf@mdc-berlin.de> <87poramg09.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFdKx-0003I6-AR for guix-devel@gnu.org; Wed, 22 Jun 2016 04:16:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFdKr-0002Cw-At for guix-devel@gnu.org; Wed, 22 Jun 2016 04:16:38 -0400 In-Reply-To: <87poramg09.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 21 Jun 2016 22:41:26 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-06-21 23:41 +0300) wrote: > Ricardo Wurmus skribis: > >> Alex Kost writes: >> >>> Ricardo found a problem while working on some emacs package that >>> requires EMMS: the elisp file(s) of this package is(are) not compiled. >>> >>> This happens because currently emacs-build-system adds only >>> "share/emacs/site-lisp/guix.d/" to emacs load-path when it >>> compiles elisp files, but some emacs packages (for example, emms) put >>> their files in "share/emacs/site-lisp", so this directory should also be >>> added. The attached patch will do it. >> >> Thank you for the patch! This looks like the right thing to do. > > +1 Pushed, thanks. >> Should we also (in a later patch) add a way to override or append to the >> list of directories, e.g. via the =E2=80=9Carguments=E2=80=9C field? > > FWIW I=E2=80=99m not convinced this is necessary, but we can always see l= ater. I agree: we can add this feature later if it will be needed. But currently it is not needed, as all our emacs packages put *.el files either in "share/emacs/site-lisp" or in "share/emacs/site-lisp/guix.d/". --=20 Alex