From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] build: emacs: Search elisp files in "share/emacs/site-lisp".
Date: Wed, 22 Jun 2016 11:16:32 +0300 [thread overview]
Message-ID: <87y45xtz8f.fsf@gmail.com> (raw)
In-Reply-To: <87poramg09.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 21 Jun 2016 22:41:26 +0200")
Ludovic Courtès (2016-06-21 23:41 +0300) wrote:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> Alex Kost <alezost@gmail.com> writes:
>>
>>> Ricardo found a problem while working on some emacs package that
>>> requires EMMS: the elisp file(s) of this package is(are) not compiled.
>>>
>>> This happens because currently emacs-build-system adds only
>>> "share/emacs/site-lisp/guix.d/<package>" to emacs load-path when it
>>> compiles elisp files, but some emacs packages (for example, emms) put
>>> their files in "share/emacs/site-lisp", so this directory should also be
>>> added. The attached patch will do it.
>>
>> Thank you for the patch! This looks like the right thing to do.
>
> +1
Pushed, thanks.
>> Should we also (in a later patch) add a way to override or append to the
>> list of directories, e.g. via the “arguments“ field?
>
> FWIW I’m not convinced this is necessary, but we can always see later.
I agree: we can add this feature later if it will be needed. But currently
it is not needed, as all our emacs packages put *.el files either in
"share/emacs/site-lisp" or in "share/emacs/site-lisp/guix.d/<package>".
--
Alex
next prev parent reply other threads:[~2016-06-22 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 13:10 [PATCH] build: emacs: Search elisp files in "share/emacs/site-lisp" Alex Kost
2016-06-21 19:29 ` Ricardo Wurmus
2016-06-21 20:41 ` Ludovic Courtès
2016-06-22 8:16 ` Alex Kost [this message]
2016-06-23 5:30 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y45xtz8f.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.