Re: [PATCH 08/10] gnu: Add python-email-validator and python2-email-validator.

[ludo@gnu.org (Ludovic Courtès)]

iyzsong@member.fsf.org (宋文武) skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Thu, Jun 23, 2016 at 11:20:02PM +0800, 宋文武 wrote:
>>> * gnu/packages/python.scm (python-email-validator)
>>> (python2-email-validator): New variables.
>>> ---
>>>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>>>  1 file changed, 32 insertions(+)
>>> 
>>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>>> index ff3cb99..68123cc 100644
>>> --- a/gnu/packages/python.scm
>>> +++ b/gnu/packages/python.scm
>>> @@ -9468,3 +9468,35 @@ It supports TSIG authenticated messages and EDNS0.")
>>>  (define-public python2-dnspython
>>>    (package-with-python2 python-dnspython))
>>>  
>>> +(define-public python-email-validator
>>> +  (package
>>> +    (name "python-email-validator")
>>> +    (version "1.0.1")
>>> +    (source
>>> +     (origin (method url-fetch)
>>> +             (uri (pypi-uri "email_validator" version))
>>> +             (sha256
>>> +              (base32
>>> +               "0mn8jg5h8ifl8w6a6m0hq8kbk0mzw9vm054qfamkn89b3npz52qw"))))
>>
>> The indentation should be shifted to the right.
> OK.
>
>>
>>> +    (build-system python-build-system)
>>> +    (arguments
>>> +     '(#:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-before 'build 'use-dnspython
>>> +           (lambda _
>>> +             (substitute* "setup.py"
>>> +               (("dnspython3") "dnspython"))
>>> +             #t)))))
>>> +    (native-inputs
>>> +     `(("python-dnspython" ,python-dnspython)
>>> +       ("python-idna" ,python-idna)
>>
>> Do dnspython and idna need to be native-inputs? Are they only used to
>> build?
> They're needed at runtime, and included in the pth file.
> But I'm not sure whether or not inputs for python should be
> native-inputs, I never cross build python modules for other
> architertures.

If they’re used at run time, they’re not ‘native-inputs’.  (In practice
we cannot cross-compile Python stuff currently, so this is largely a
theoretical concern, but it doesn’t cost much to get it right.)

> Should I put dnspython and idna into inputs, or propagated-inputs?

If the installed code “import”s them, then they should be propagated.

Ludo’.