all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.
Date: Thu, 21 Jul 2016 14:24:36 +0200	[thread overview]
Message-ID: <87y44vnpq3.fsf@gnu.org> (raw)
In-Reply-To: <CAL1_immZV=_J6ZmGqyUs5bP3x_f-weUvPp4E4unViTtZ0OwjdA@mail.gmail.com> (David Craven's message of "Wed, 20 Jul 2016 12:50:49 +0200")

David Craven <david@craven.ch> skribis:

>> I think packages with a “bin” output are not always used as native
>> inputs, so I would drop this rule.
>
> From searching the code-base we have I couldn't find a counter example. Do
> you think it's ok to check for glib:bin specifically?

Yes, sounds good to me.

However, make sure to match on the package name + output, not on the
label.  That is, ‘lint’ should correctly diagnose something like:

  (inputs `(("somethingsilly" ,glib "bin")))

Thanks!

Ludo’.

  parent reply	other threads:[~2016-07-21 12:24 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 16:49 [PATCH 0/4] Dipping my toes into guix source David Craven
2016-07-19 16:49 ` [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native' David Craven
2016-07-20 10:37   ` Ludovic Courtès
2016-07-20 10:50     ` David Craven
2016-07-20 11:19       ` Efraim Flashner
2016-07-21 12:24       ` Ludovic Courtès [this message]
2016-07-21 13:22         ` Vincent Legoll
2016-07-21 16:06           ` Ludovic Courtès
2016-07-21 19:27             ` Tobias Geerinckx-Rice
2016-07-22 13:32               ` Ludovic Courtès
2016-07-22 14:07                 ` Vincent Legoll
2016-07-19 16:49 ` [PATCH 2/4] gnu: Rename 'glib' label to 'glib:bin' where appropriate David Craven
2016-07-22 12:57   ` Ludovic Courtès
2016-07-22 13:03     ` David Craven
2016-07-22 17:55       ` David Craven
2016-07-19 16:49 ` [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check David Craven
2016-07-21 13:17   ` Eric Bavier
2016-07-21 16:00     ` Ludovic Courtès
2016-07-19 16:49 ` [PATCH 4/4] environment: Add '--debug' flag David Craven
2016-07-19 17:14   ` Thompson, David
2016-07-19 18:00     ` Tobias Geerinckx-Rice
2016-07-19 18:10       ` David Craven
2016-07-19 19:02         ` David Craven
2016-07-19 19:06           ` Thompson, David
2016-07-19 19:15             ` David Craven
2016-07-20  4:17           ` Leo Famulari
2016-07-20 10:35         ` Ludovic Courtès
2016-07-20 10:56           ` David Craven
2016-07-19 20:11       ` Danny Milosavljevic
2016-07-20  7:18         ` Alex Kost
2016-07-20  7:35           ` Vincent Legoll
2016-07-20  9:15           ` Pjotr Prins
2016-07-22 19:54         ` Customising linux-libre (was: [PATCH 4/4] environment: Add '--debug' flag.) Tobias Geerinckx-Rice
2016-07-22 19:58           ` Vincent Legoll
2016-07-22 20:00             ` David Craven
2016-07-22 20:03               ` Vincent Legoll
2016-07-22 20:15               ` Customising linux-libre Tobias Geerinckx-Rice
2016-07-22 20:50                 ` David Craven
2016-07-22 20:11             ` Tobias Geerinckx-Rice
2016-07-23 10:38               ` Ludovic Courtès
2016-07-21 12:22   ` [PATCH 4/4] environment: Add '--debug' flag Ludovic Courtès
2016-07-21 12:30     ` David Craven
2016-07-21 16:03       ` Ludovic Courtès
2016-07-21 16:12         ` David Craven
2016-07-21 16:38           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y44vnpq3.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.