all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 24060@debbugs.gnu.org
Subject: bug#24060: Test (tests/publish.scm) still fails after fix
Date: Thu, 28 Jul 2016 23:20:00 +0200	[thread overview]
Message-ID: <87y44lv4sf.fsf@gnu.org> (raw)
In-Reply-To: <87twf94ug1.fsf@gmail.com> (Chris Marusich's message of "Thu, 28 Jul 2016 09:07:58 -0700")

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

Hi,

Chris Marusich <cmmarusich@gmail.com> skribis:

> I tried running the tests against commit
> 37402ecb4379d7199dd4b3386488261938edc780, but this time the test fails
> for a different reason.  Does it succeed for you?

Yes.

Is this new failure systematic, or does it occur randomly?

> publishing /home/marusich/guix/test-tmp/store on 0.0.0.0, port 6799
> GET /z8qsg9bmmjzgfi0bbgls1wxd0wmhhm2i.narinfo
> guile: ports.c:2527: scm_i_port_iconv_descriptors: Assertion `pti->encoding_mode == SCM_PORT_ENCODING_MODE_ICONV' failed.

What version of Guile do you use?

I wonder if this could be a remnant of <http://bugs.gnu.org/19610>.
Does commenting out the “/nar/gzip/*” test hide the problem?

If so, does the patch below help?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 860 bytes --]

$ git diff HEAD
diff --git a/tests/publish.scm b/tests/publish.scm
index 4dc8075..fda0b7c 100644
--- a/tests/publish.scm
+++ b/tests/publish.scm
@@ -172,11 +172,13 @@ References: ~%"
   "bar"
   (call-with-temporary-output-file
    (lambda (temp port)
-     (let ((nar (http-get-port
-                 (publish-uri
-                  (string-append "/nar/gzip/" (basename %item))))))
-       (call-with-gzip-input-port nar
-         (cut restore-file <> temp)))
+     (let* ((nar  (http-get-port
+                   (publish-uri
+                    (string-append "/nar/gzip/" (basename %item)))))
+            (data (call-with-gzip-input-port nar
+                    get-bytevector-all))
+            (input (open-bytevector-input-port data)))
+       (restore-file input temp))
      (call-with-input-file temp read-string))))
 
 (unless (zlib-available?)

  reply	other threads:[~2016-07-28 21:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24  9:31 bug#24060: Test failure: tests/publish.scm Chris Marusich
2016-07-24 23:01 ` Chris Marusich
2016-07-26 21:08 ` Ludovic Courtès
2016-07-27 10:49 ` Ludovic Courtès
2016-07-28 16:07 ` bug#24060: Test (tests/publish.scm) still fails after fix Chris Marusich
2016-07-28 21:20   ` Ludovic Courtès [this message]
2016-07-30  7:59     ` Chris Marusich
2016-07-30  9:16       ` Ludovic Courtès
2016-08-02 16:10       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y44lv4sf.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=24060@debbugs.gnu.org \
    --cc=cmmarusich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.