From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add p7zip.
Date: Tue, 2 Aug 2016 09:06:13 +0200
Message-ID: <87y44f4plm.fsf@mdc-berlin.de>
References: <87a8gwxa9c.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bUUFy-0000Bm-7B
	for guix-devel@gnu.org; Tue, 02 Aug 2016 03:36:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bUUFr-0008La-7K
	for guix-devel@gnu.org; Tue, 02 Aug 2016 03:36:52 -0400
Received: from sinope02.bbbm.mdc-berlin.de ([141.80.25.24]:46270)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bUUEN-00089X-6N
	for guix-devel@gnu.org; Tue, 02 Aug 2016 03:36:47 -0400
In-Reply-To: <87a8gwxa9c.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org


Hi Kei,

> This patch should install p7zip correctly on every architecture
> supported by Guix. Ideally, this should be tested it on each arch for
> the sake of completeness and safety. I've got x86_64 covered so far. :-=
)

thank you for this patch!

I see that you took care of removing non-free parts in a patch and a
build phase.  Since =E2=80=9Cguix build -S p7zip=E2=80=9D doesn=E2=80=99t=
 run the build phase
users would still end up with a source archive containing the non-free
parts.  The best way is thus to remove things in a snippet.

In =E2=80=9Cshogun=E2=80=9D from the =E2=80=9Cmachine-learning=E2=80=9D m=
odule we remove supporting code
for non-free features in a snippet by cutting out anything between some
ifdef markers, but looking at the patch I see that it wouldn=E2=80=99t be
feasible for p7zip.

About the new configure phase: I think you could avoid copying the
Makefile by using =E2=80=9C#:make-flags=E2=80=9D similar to this:

    #:make-flags
    (list (string-append "-f "
                         ((string-prefix? "x86_64" system)
                          "makefile.linux_amd64_asm")
                         =E2=80=A6)

What do you think?

~~ Ricardo