From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info. Date: Wed, 17 Aug 2016 05:33:03 -0400 Message-ID: <87y43vwxio.fsf@netris.org> References: <20160816183938.22794-1-david@craven.ch> <20160816183938.22794-12-david@craven.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZxEm-0003A5-Lw for guix-devel@gnu.org; Wed, 17 Aug 2016 05:34:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZxEi-0001xj-Vl for guix-devel@gnu.org; Wed, 17 Aug 2016 05:34:15 -0400 Received: from world.peace.net ([50.252.239.5]:54140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZxEi-0001xV-Rt for guix-devel@gnu.org; Wed, 17 Aug 2016 05:34:12 -0400 In-Reply-To: <20160816183938.22794-12-david@craven.ch> (David Craven's message of "Tue, 16 Aug 2016 20:39:26 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel@gnu.org David Craven writes: > * gnu/packages/gnome.scm (mobile-broadband-provider-info): New variable. The summary line to should be "gnu: Add mobile-broadband-provider-info." without the "gnome: ". By our conventions, starting a summary line with "gnu: gnome: " indicates a change to the 'gnome' package, which is not the case here, and leads to confusion in practice. I read this summary line as meaning that 'mobile-broadband-provider-info' was added to gnome's propagated-inputs. This same issue applies to the other patches in this patch set as well. When adding new packages, our convention is simply to write "gnu: Add ." Thanks, Mark > --- > gnu/packages/gnome.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 4a0be01..7bc0445 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -21,6 +21,7 @@ > ;;; Copyright =C2=A9 2016 Leo Famulari > ;;; Copyright =C2=A9 2016 Alex Griffin > ;;; Copyright =C2=A9 2016 ng0 > +;;; Copyright =C2=A9 2016 David Craven > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -4460,6 +4461,27 @@ devices, and provides VPN integration with a varie= ty of different VPN > services.") > (license license:gpl2+))) >=20=20 > +(define-public mobile-broadband-provider-info > + (package > + (name "mobile-broadband-provider-info") > + (version "20151214") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnome/sources/" > + "mobile-broadband-provider-info/" version "/" > + "mobile-broadband-provider-info-" version ".tar.xz")) > + (sha256 > + (base32 > + "1905nab1h8p4hx0m1w0rn4mkg9209x680dcr4l77bngy21pmvr4a"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f)) ; No tests > + (home-page "https://wiki.gnome.org/Projects/NetworkManager") > + (synopsis "Datbase of broadband connection configuration") > + (description "Datbase of broadband connection configuration.") > + (license license:public-domain))) > + > (define-public network-manager-applet > (package > (name "network-manager-applet")