From: Mark H Weaver <mhw@netris.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info.
Date: Wed, 17 Aug 2016 05:33:03 -0400 [thread overview]
Message-ID: <87y43vwxio.fsf@netris.org> (raw)
In-Reply-To: <20160816183938.22794-12-david@craven.ch> (David Craven's message of "Tue, 16 Aug 2016 20:39:26 +0200")
David Craven <david@craven.ch> writes:
> * gnu/packages/gnome.scm (mobile-broadband-provider-info): New variable.
The summary line to should be "gnu: Add mobile-broadband-provider-info."
without the "gnome: ". By our conventions, starting a summary line with
"gnu: gnome: " indicates a change to the 'gnome' package, which is not
the case here, and leads to confusion in practice. I read this summary
line as meaning that 'mobile-broadband-provider-info' was added to
gnome's propagated-inputs.
This same issue applies to the other patches in this patch set as well.
When adding new packages, our convention is simply to write "gnu: Add
<package-name>."
Thanks,
Mark
> ---
> gnu/packages/gnome.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 4a0be01..7bc0445 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -21,6 +21,7 @@
> ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
> ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
> ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016 David Craven <david@craven.ch>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -4460,6 +4461,27 @@ devices, and provides VPN integration with a variety of different VPN
> services.")
> (license license:gpl2+)))
>
> +(define-public mobile-broadband-provider-info
> + (package
> + (name "mobile-broadband-provider-info")
> + (version "20151214")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://gnome/sources/"
> + "mobile-broadband-provider-info/" version "/"
> + "mobile-broadband-provider-info-" version ".tar.xz"))
> + (sha256
> + (base32
> + "1905nab1h8p4hx0m1w0rn4mkg9209x680dcr4l77bngy21pmvr4a"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f)) ; No tests
> + (home-page "https://wiki.gnome.org/Projects/NetworkManager")
> + (synopsis "Datbase of broadband connection configuration")
> + (description "Datbase of broadband connection configuration.")
> + (license license:public-domain)))
> +
> (define-public network-manager-applet
> (package
> (name "network-manager-applet")
next prev parent reply other threads:[~2016-08-17 9:34 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
2016-08-16 18:39 ` [PATCH 02/24] gnu: qt: Add qtquickcontrols2 David Craven
2016-08-16 18:39 ` [PATCH 03/24] gnu: qt: Add qtgraphicaleffects David Craven
2016-08-16 19:29 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 04/24] gnu: databases: Add lmdb David Craven
2016-08-16 18:39 ` [PATCH 05/24] gnu: xml: Add yaml-cpp David Craven
2016-08-16 19:58 ` Alex Kost
2016-08-16 18:39 ` [PATCH 06/24] gnu: xml: Add jsoncpp David Craven
2016-08-16 19:28 ` Danny Milosavljevic
2016-08-16 19:59 ` Danny Milosavljevic
2016-08-16 20:00 ` Alex Kost
2016-08-16 18:39 ` [PATCH 07/24] gnu: compression: Add snappy David Craven
2016-08-16 19:45 ` Alex Kost
2016-08-16 18:39 ` [PATCH 08/24] gnu: xorg: Add lndir David Craven
2016-08-16 19:53 ` Alex Kost
2016-08-16 18:39 ` [PATCH 09/24] gnu: freedesktop: Add wayland-protocols David Craven
2016-08-16 19:51 ` Danny Milosavljevic
2016-08-16 20:02 ` Alex Kost
2016-08-16 18:39 ` [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager David Craven
2016-08-16 20:07 ` Alex Kost
2016-08-16 18:39 ` [PATCH 11/24] gnu: modemmanager-qt: Propagate modem-manager David Craven
2016-08-16 18:39 ` [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info David Craven
2016-08-16 19:53 ` Danny Milosavljevic
2016-08-17 9:33 ` Mark H Weaver [this message]
2016-08-17 9:37 ` David Craven
2016-08-16 18:39 ` [PATCH 13/24] gnu: polkit-qt: Use modular qt David Craven
2016-08-16 19:17 ` Danny Milosavljevic
2016-08-16 21:00 ` Leo Famulari
2016-08-16 18:39 ` [PATCH 14/24] gnu: gstreamer: Use license: prefix David Craven
2016-08-16 19:18 ` Danny Milosavljevic
2016-08-16 20:15 ` Alex Kost
2016-08-16 20:29 ` David Craven
2016-08-16 22:38 ` Eric Bavier
2016-08-17 8:02 ` David Craven
2016-08-17 8:47 ` Danny Milosavljevic
2016-08-17 8:53 ` David Craven
2016-08-17 9:17 ` Danny Milosavljevic
2016-08-17 9:20 ` David Craven
2016-08-16 18:39 ` [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory David Craven
2016-08-17 9:28 ` Mark H Weaver
2016-08-17 9:35 ` David Craven
2016-08-17 9:57 ` Mark H Weaver
2016-08-17 10:10 ` David Craven
2016-08-16 18:39 ` [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer David Craven
2016-08-16 21:08 ` Leo Famulari
2016-08-16 22:28 ` Eric Bavier
2016-08-16 18:39 ` [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure David Craven
2016-08-16 19:22 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 18/24] gnu: qsynth: Use modular qt David Craven
2016-08-16 19:16 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 19/24] gnu: fritzing: " David Craven
2016-08-16 19:17 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 20/24] gnu: bitcoin-core: " David Craven
2016-08-16 19:23 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 21/24] gnu: gst-plugins-bad: " David Craven
2016-08-16 19:23 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 22/24] gnu: poppler-qt5: " David Craven
2016-08-16 19:24 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 23/24] gnu: qtkeychain: " David Craven
2016-08-16 19:25 ` Danny Milosavljevic
2016-08-16 18:39 ` [PATCH 24/24] gnu: qt: Update qt to 5.7.0 David Craven
2016-08-16 19:41 ` Danny Milosavljevic
2016-08-19 0:28 ` Mark H Weaver
2016-08-19 8:56 ` David Craven
2016-08-19 18:41 ` Mark H Weaver
2016-08-19 18:45 ` David Craven
2016-08-20 15:40 ` David Craven
2016-08-20 18:50 ` Mark H Weaver
2016-08-20 19:50 ` David Craven
2016-08-20 20:06 ` Efraim Flashner
2016-08-20 21:59 ` Leo Famulari
2016-08-21 14:08 ` [PATCH 01/13] gnu: kguiaddons: Fix regression caused by update to qt 5.7 David Craven
2016-08-21 14:08 ` [PATCH 02/13] gnu: kwidgetsaddons: " David Craven
2016-08-21 19:48 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 03/13] gnu: pinentry-qt: Fix regression David Craven
2016-08-21 20:16 ` Mark H Weaver
2016-08-21 22:37 ` David Craven
2016-08-21 14:08 ` [PATCH 04/13] gnu: poppler: Update to 0.47.0 David Craven
2016-08-21 19:52 ` Mark H Weaver
2016-08-21 22:40 ` David Craven
2016-08-21 14:08 ` [PATCH 05/13] gnu: alsa-modular-synth: Fix regression caused by update to qt 5.7 David Craven
2016-08-21 19:53 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 06/13] gnu: qsynth: " David Craven
2016-08-21 19:55 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 07/13] gnu: gpsbabel: " David Craven
2016-08-21 19:59 ` Mark H Weaver
2016-08-21 22:55 ` David Craven
2016-08-21 14:08 ` [PATCH 08/13] gnu: synthv1: " David Craven
2016-08-21 20:01 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 09/13] gnu: scribus: " David Craven
2016-08-21 20:02 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 10/13] gnu: v4l-utils: " David Craven
2016-08-21 20:04 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 11/13] gnu: vlc: " David Craven
2016-08-21 20:10 ` Mark H Weaver
2016-08-21 23:06 ` David Craven
2016-08-21 23:16 ` Leo Famulari
2016-08-21 23:19 ` David Craven
2016-08-21 23:24 ` Leo Famulari
2016-08-21 23:24 ` David Craven
2016-08-22 12:21 ` Mark H Weaver
2016-08-21 14:08 ` [PATCH 12/13] gnu: avidemux: " David Craven
2016-08-21 20:13 ` Mark H Weaver
2016-08-21 21:08 ` David Craven
2016-08-21 19:44 ` [PATCH 01/13] gnu: kguiaddons: " Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y43vwxio.fsf@netris.org \
--to=mhw@netris.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.