all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.
Date: Wed, 17 Aug 2016 20:53:25 +0300	[thread overview]
Message-ID: <87y43vqo2y.fsf@gmail.com> (raw)
In-Reply-To: <CAL1_imk+19BvHWb80EgSPrkj=tZLn8vnQJNGh==_f9CcuhQCFQ@mail.gmail.com> (David Craven's message of "Wed, 17 Aug 2016 11:34:00 +0200")

David Craven (2016-08-17 12:34 +0300) wrote:

>> Also there should be a reason for propagating (probably written as a
>> comment).  Ideally it should be avoided.
>
> I added comments:
>
> (propagated-inputs
>       ; Headers contain #include <NetworkManager.h> and
>       ;                            #include <libnm/NetworkManager.h>
>       `(("network-manager" ,network-manager)))
>
> (propagated-inputs
>      ; Headers contain #include <ModemManager/ModemManager.h>
>      `(("modem-manager", modem-manager)))

These comments should begin with ";;", not with ";".  Sorry, but I still
don't understand the reason.  What exactly does not work when these are
simple inputs?  Is it possible to avoid propagating?

-- 
Alex

  reply	other threads:[~2016-08-17 17:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17  9:34 [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager David Craven
2016-08-17 17:53 ` Alex Kost [this message]
2016-08-17 18:14   ` David Craven
2016-08-18  7:25     ` Alex Kost
  -- strict thread matches above, loose matches on Subject: below --
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
2016-08-16 18:39 ` [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager David Craven
2016-08-16 20:07   ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y43vqo2y.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.