Re: [PATCH] Add bwm-ng.

[ng0 <ng0@we.make.ritual.n0.is>]

Hi Arun,

thanks for your contribution.

Arun <arunisaac@systemreboot.net> writes:

> [ Unknown signature status ]
>
> Please find attached patch to add new package 'bwm-ng' to (gnu packages
> admin).
>
> Regards,
> Arun Isaac
>
> From 2a88508183f9b8005c2a0694992f1b3ae4208049 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Wed, 24 Aug 2016 23:49:46 +0530
> Subject: [PATCH] gnu: Add bwm-ng.
> To: guix-devel@gnu.org
>
> * gnu/packages/admin.scm (bwm-ng): New variable.
> ---
>  gnu/packages/admin.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 3ba5947..d3da2d8 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1767,3 +1767,21 @@ the status of your battery in the system tray.")
>  shortcut syntax and completion options.")
>        (home-page "https://github.com/TrilbyWhite/interrobang")
>        (license license:gpl3+))))
> +
> +(define-public bwm-ng
> +  (package
> +    (name "bwm-ng")
> +    (version "0.6.1")
> +    (source
> +     (origin
> +       (method url-fetch)

The package is good and well written. Whoever commits it, can make the
stylistic adjustments. I can not commit, but I can tell you that your
package builds here and that the section below will be corrected to

> +       (uri (string-append "https://www.gropp.org/bwm-ng/bwm-ng-" version ".tar.gz"))
> +       (sha256 (base32 "1w0dwpjjm9pqi613i8glxrgca3rdyqyp3xydzagzr5ndc34z6z02"))))

(uri
  (string-append "https://www.gropp.org/bwm-ng/"
                 name "-" version ".tar.gz"))
(sha256
  (base32
    "1w0dwpjjm9pqi613i8glxrgca3rdyqyp3xydzagzr5ndc34z6z02"))))

Or something similar to this. These are just minor details, so don't
worry about them now, same goes for:

> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses" ,ncurses)))

(inputs
  `(("ncurses" ,ncurses)))

which would be my choice, but a simple one line works too.

> +    (synopsis "Console based live network and disk I/O bandwidth monitor")
> +    (description "Bandwidth Monitor NG is a small and simple
> +console based live network and disk I/O bandwidth monitor for Linux,
> +BSD, Solaris, Mac OS X and others.")
> +    (home-page "https://www.gropp.org/?id=projects&sub=bwm-ng")
> +    (license license:gpl2)))
> -- 
> 2.9.3
>

For a first(?) package this is very good.
Other than these changes, which the person commiting your patch can
apply on your behalf, it looks good to me!
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org