From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 0/2] Fix IBus input methods. Date: Sat, 03 Sep 2016 15:54:47 +0200 Message-ID: <87y439ks0o.fsf@gnu.org> References: <20160824220937.8745-1-rekado@elephly.net> <87k2f5cdkz.fsf@member.fsf.org> <87zio1njzj.fsf@elephly.net> <87inuejvdr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgBPL-0001NF-Ty for guix-devel@gnu.org; Sat, 03 Sep 2016 09:55:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgBPH-0005Pp-UH for guix-devel@gnu.org; Sat, 03 Sep 2016 09:54:55 -0400 In-Reply-To: (Ricardo Wurmus's message of "Fri, 2 Sep 2016 16:19:24 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >> Ricardo Wurmus skribis: >> >>> =E5=AE=8B=E6=96=87=E6=AD=A6 writes: >>> >>>> Ricardo Wurmus writes: >>>> >>>>> gnu: gtk+-2: Add patch to support GUIX_GTK2_IM_MODULE_FILE. >>>>> gnu: gtk+: Add patch to support GUIX_GTK3_IM_MODULE_FILE. >>>> >>>> Look good to me! >>> >>> Thanks! >>> >>> What do you think: should this be a separate branch (e.g. =E2=80=9Cgtk-= rebuild=E2=80=9D) >>> or should it be pushed to =E2=80=9Ccore-updates=E2=80=9D? >> >> As discussed on IRC, I=E2=80=99ve added a =E2=80=9Cjobset=E2=80=9D: >> >> https://hydra.gnu.org/jobset/gnu/gtk-im-modules >> >> There seems to be only 1 new failure compared to =E2=80=98master=E2=80= =99: >> >> https://hydra.gnu.org/eval/109124?compare=3Dmaster#tabs-now-fail >> >> Could you take a look? > > This looks unrelated to me. OK. >> We=E2=80=99ll have to merge =E2=80=98master=E2=80=99 into it and evaluat= e it again. > > Can =E2=80=9Cgtk-im-modules=E2=80=9D not be merged into the master branch= directly? One benefit of having a separate jobset is that we can wait until everything is built before merging to master. The problem here is that this branch was entirely built several days ago, so it might be somewhat outdated now. Thus, could you either (1) merge locally into master and make sure no important binaries are missing (try =E2=80=9Cguix build emacs -n=E2=80=9D o= r similar), and if that is the case, you can push; or (2) merge master into gtk-im-modules and reevaluate the jobset? Thanks in advance! :-) Ludo=E2=80=99.