From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 07/12] import: crate: Add crate updater.
Date: Mon, 26 Sep 2016 12:09:42 +0200 [thread overview]
Message-ID: <87y42fkm55.fsf@gnu.org> (raw)
In-Reply-To: <20160922131903.1606-7-david@craven.ch> (David Craven's message of "Thu, 22 Sep 2016 15:18:58 +0200")
David Craven <david@craven.ch> skribis:
> * guix/import/crate.scm (crate-package?, latest-release,
> %crate-updater): New variables.
> * guix/scripts/refresh.scm (%updaters): Add %crate-updater to list of
> updaters.
> * guix/upstream.scm (package-update): Use a url from the list when the
> find2 procedure doesn't find a url sig-url pair.
Neat!
> +(define (latest-release package)
> + "Return an <upstream-source> for the latest release of PACKAGE."
> + (let* ((crate-name (guix-package->crate-name package))
> + (metadata (crate-fetch crate-name))
> + (version (assoc-ref* metadata "crate" "max_version"))
> + (url (crate-uri crate-name version)))
> + (upstream-source
> + (package (package-name package))
> + (version version)
> + (urls (list url)))))
So they don’t publish OpenPGP signatures? :-/
> --- a/guix/upstream.scm
> +++ b/guix/upstream.scm
> @@ -194,7 +194,7 @@ and 'interactive' (default)."
> (string-suffix? archive-type url))
> urls
> (or signature-urls (circular-list #f)))))
> - (let ((tarball (download-tarball store url signature-url
> + (let ((tarball (download-tarball store (if url url (car urls)) signature-url
I don’t understand this part, and I suspect it could lead to
inconsistent results where the signature URL doesn’t match the source
URL.
Do you have an example of the problem you experienced? Since the
problem is probably not specific to Crates, we should probably address
it in a separate patch.
Otherwise LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-09-26 15:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 13:18 [PATCH 01/12] import: Move json-fetch to (guix import utils) David Craven
2016-09-22 13:18 ` [PATCH 02/12] import: Reorder imports in " David Craven
2016-09-26 9:31 ` Ludovic Courtès
2016-09-22 13:18 ` [PATCH 03/12] import: Move string->license to importers David Craven
2016-09-26 9:32 ` Ludovic Courtès
2016-09-22 13:18 ` [PATCH 04/12] import: utils: Add spdx-string->license David Craven
2016-09-22 14:56 ` Eric Bavier
2016-09-22 15:15 ` David Craven
2016-09-26 9:33 ` Ludovic Courtès
2016-09-22 13:18 ` [PATCH 05/12] import: utils: Refactor license->symbol David Craven
2016-09-26 9:39 ` Ludovic Courtès
2016-09-22 13:18 ` [PATCH 06/12] import: Add importer for rust crates David Craven
2016-09-26 10:02 ` Ludovic Courtès
2016-09-22 13:18 ` [PATCH 07/12] import: crate: Add crate updater David Craven
2016-09-26 10:09 ` Ludovic Courtès [this message]
2016-09-22 13:18 ` [PATCH 08/12] build-system: Add cargo build system David Craven
2016-09-26 10:17 ` Ludovic Courtès
2016-09-26 18:01 ` David Craven
2016-09-30 12:13 ` Ludovic Courtès
2016-09-22 13:19 ` [PATCH 09/12] gnu: Add rust-bootstrap-x86_64-1.12.0 David Craven
2016-09-26 10:18 ` Ludovic Courtès
2016-09-22 13:19 ` [PATCH 10/12] gnu: Add rustc-bootstrap David Craven
2016-09-26 10:24 ` Ludovic Courtès
2016-09-22 13:19 ` [PATCH 11/12] gnu: Add cargo-bootstrap David Craven
2016-09-26 10:28 ` Ludovic Courtès
2016-09-22 13:19 ` [PATCH 12/12] gnu: Add rust helper functions David Craven
2016-09-26 10:29 ` Ludovic Courtès
2016-09-22 14:58 ` [PATCH 01/12] import: Move json-fetch to (guix import utils) Eric Bavier
2016-09-22 15:23 ` David Craven
2016-09-22 16:52 ` Eric Bavier
2016-09-22 16:56 ` David Craven
2016-09-24 5:20 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y42fkm55.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.