From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH v2 00/13]: Add asdf-build-system. Date: Fri, 07 Oct 2016 08:59:05 +0800 Message-ID: <87y421j7om.fsf@member.fsf.org> References: <20160927041532.27097-1-ajpatter@uwaterloo.ca> <20161003024139.19975-1-ajpatter@uwaterloo.ca> <874m4pgpe1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsJh8-0005GZ-34 for guix-devel@gnu.org; Thu, 06 Oct 2016 21:11:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsJh3-0003bt-0v for guix-devel@gnu.org; Thu, 06 Oct 2016 21:11:24 -0400 In-Reply-To: <874m4pgpe1.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 06 Oct 2016 23:04:54 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi! > > Andy Patterson skribis: > >> Here's the next round of the series. In addition to the changes proposed= by >> =E5=AE=8B=E6=96=87=E6=AD=A6, I homogenized the phases of the compiled pa= ckages, in order to >> simplify transformations. I also added a package transformer system simi= lar to >> package-with-python2. Finally, I decided to have all packages bundle a c= opy of >> their source, and use it while building, rather than using the source pa= ckages >> as a build input, which had some complications. >> >> Further comments are appreciated. > > =E5=AE=8B=E6=96=87=E6=AD=A6, I take it that you=E2=80=99ll be looking at = this patch series, right? > If you=E2=80=99d like others to chime in, please let us know. :-) > Yes, at this point Andy Patterson had addressed most my questions in his latest reply, so I plan to merge them once a new 'asdf-build-system' patch is out (fix typo, add more document, etc.) and if no new concerns appear. It will be great if others review and comment on them too, in case I overlooked something :-)