all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: cups-filters: Use ghostscript with CUPS driver.
Date: Sun, 09 Oct 2016 16:17:38 +0200	[thread overview]
Message-ID: <87y41xfvy5.fsf@elephly.net> (raw)
In-Reply-To: <20161007202424.26732-2-wingo@igalia.com>


Andy Wingo <wingo@igalia.com> writes:

> * gnu/packages/cups.scm (ghostscript/cups): New variable.
>   (cups-filters): Use ghostscript/cups.  Capture path to "gs" at
>   compilation time.
> ---
>  gnu/packages/cups.scm | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm
> index d22338d..8394bfb 100644
> --- a/gnu/packages/cups.scm
> +++ b/gnu/packages/cups.scm
> @@ -40,6 +40,14 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages tls))
>  
> +;; Delay to avoid module circularity problems.
> +(define ghostscript/cups
> +  (delay
> +    (package (inherit ghostscript)
> +      (name "ghostscript-with-cups")
> +      (inputs `(("cups" ,cups-minimal)
> +                ,@(package-inputs ghostscript))))))
> +
>  (define-public cups-filters
>    (package
>      (name "cups-filters")
> @@ -78,6 +86,9 @@
>         `(,(string-append "--with-test-font-path="
>                           (assoc-ref %build-inputs "font-dejavu")
>                           "/share/fonts/truetype/DejaVuSans.ttf")
> +         ,(string-append "--with-gs-path="
> +                         (assoc-ref %build-inputs "ghostscript")
> +                         "/bin/gsc")
>           ,(string-append "--with-rcdir="
>                           (assoc-ref %outputs "out") "/etc/rc.d"))))
>      (native-inputs
> @@ -87,7 +98,7 @@
>       `(("fontconfig"   ,fontconfig)
>         ("freetype"     ,freetype)
>         ("font-dejavu"  ,font-dejavu) ;needed by test suite
> -       ("ghostscript"  ,ghostscript)
> +       ("ghostscript"  ,(force ghostscript/cups))
>         ("ijs"          ,ijs)
>         ("dbus"         ,dbus)
>         ("lcms"         ,lcms)

This also looks good to me.

~~ Ricardo

  reply	other threads:[~2016-10-09 14:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 20:24 [PATCH 1/3] gnu: cups-filters: Look for test page in own output dir Andy Wingo
2016-10-07 20:24 ` [PATCH 2/3] gnu: cups-filters: Use ghostscript with CUPS driver Andy Wingo
2016-10-09 14:17   ` Ricardo Wurmus [this message]
2016-10-10 12:50   ` Ludovic Courtès
2016-10-07 20:24 ` [PATCH 3/3] gnu: Add CUPS service Andy Wingo
2016-10-08  8:37   ` Andy Wingo
2016-10-09 13:02     ` Christopher Allan Webber
2016-10-09 14:37   ` Ricardo Wurmus
2016-10-10  8:32   ` Clément Lassieur
2016-10-10  8:55     ` Andy Wingo
2016-10-10 21:00       ` Ludovic Courtès
2016-10-09 14:14 ` [PATCH 1/3] gnu: cups-filters: Look for test page in own output dir Ricardo Wurmus
  -- strict thread matches above, loose matches on Subject: below --
2016-10-10 13:29 Andy Wingo
2016-10-10 13:30 ` [PATCH 2/3] gnu: cups-filters: Use ghostscript with CUPS driver Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y41xfvy5.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.