From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add opencascade-oce Date: Sat, 21 Jan 2017 13:28:51 +0100 Message-ID: <87y3y461h8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <1484738618-3156-1-git-send-email-pgarlick@tourbillion-technology.com> <87k29s8bd3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <1484827276.2709.14.camel@tourbillion-technology.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUumy-00070W-3V for guix-devel@gnu.org; Sat, 21 Jan 2017 07:29:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUumt-0000wl-4s for guix-devel@gnu.org; Sat, 21 Jan 2017 07:29:00 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37737) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cUums-0000wE-UZ for guix-devel@gnu.org; Sat, 21 Jan 2017 07:28:55 -0500 In-Reply-To: <1484827276.2709.14.camel@tourbillion-technology.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Paul Garlick , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Paul Garlick writes: > Hello Marius, > Thank you for your review. >> I wonder if this could fit in "engineering.scm". Or maybe >> "geometry.scm" >> or "3d.scm". We try to avoid "single program" modules. What do you >> think? > Perhaps maths.scm is the best place, in order to avoid creating a new > module. =C2=A0The Gmsh package is already there. OK, sounds good! > =C2=A0To check; am I right in > saying that a library in one module can be used as an input for a > package in another module? =C2=A0For example, if FreeCAD were to be > packaged, and placed in engineering.scm, could it use opencascade-oce > as an input from maths.scm? That's the intended usage; cross-references are OK too (to an extent). >> > +(define-public opencascade-oce >> > + (package >> > + (name "opencascade-oce") >> > + (version "0.17.2") >>=20 >> Version 0.18 was released a few days ago! > > It would be useful to package both versions. =C2=A0There is a difference = in > the OpenGL graphics card requirements in going from version 0.17.2 to > 0.18. That sounds sensible. Could you try packaging both versions and add a comment with 0.17 mentioning the graphics card requirement? See e.g. 'python-requests-2.7' for an example of inheriting another package. >> >=20 >> > + (license license:lgpl2.1))) ; plus header files exception >> >=20 > >>=20 >>=20 >> Please expand on the exception comment and mention >> OCCT_LGPL_EXCEPTION.txt. There are also some public domain files, and >> the bundled "gtest" is bsd-3. src/OpenGl/OpenGl_glext.h is distributed >> under the expat license. Some files generated by "bison" has GPL3+. >>=20 > > I have added the information about the expat and BSD-3 licenses. =C2=A0Can > you elaborate on the public domain files and Bison? At least these two files are public domain: src/Standard/Standard_StdAllocator.hxx src/NCollection/NCollection_StdAllocator.hxx Reading the bison generated files more closely, they contain an exception saying they can be relicensed as part of a larger work, so I think they fall under the "main" license in this case. Sorry for the confusion! Otherwise the patch looks good. I did notice that some of the inputs are not referenced as verified with `guix gc -R /gnu/store/...`. Perhaps they need some configure switches to be enabled? These inputs appear to be unused, or only needed for building: ftgl qt libtool file tk tcl Libtool and file should likely be native-inputs, not sure about the others. Could you check whether they are required and send an updated patch? Thanks in advance! This is the final round, promise ;-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliDVAMACgkQoqBt8qM6 VPrXnQf/erdAwLPmxf5puRI9gZJQyle3rZEoAUSjIgkd6XCGorq6/1J913mYEze3 g8FqtR5kdYJ6ihxak3Uvdq+xsBjXykYejtrjClkbLstIIE8i3DBy3qZPZl3Tvixm LHQey1a8r40ELdHI3x6g5py5EIXtqpFljgy/g68dCMuZ8G2+CBsNb3x3+rgZDTyT 3Zl7D32nXQRP5UNoHYgLnYAcD4pnmXJ7BN9kh6p4bSTx737v07r32Sg7Fsa/rkM4 GN958CawZNH2FDwJXFgA9xMFExnjqEA3kDR+rBIvRTo1/29H8EYtKbSuXcgUobN4 +D3EufAcFkprftqYYK+d9jETykcKbw== =lwVD -----END PGP SIGNATURE----- --=-=-=--