From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 02/05: gnu: nss, nss-certs: Update to 3.29.3. Date: Tue, 14 Mar 2017 23:12:25 +0100 Message-ID: <87y3w733ue.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170313174039.25881.89989@vcs0.savannah.gnu.org> <20170313174040.C5C6B20CAB@vcs0.savannah.gnu.org> <878to8qssk.fsf@netris.org> <87innc43ub.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <871stzh8rv.fsf@netris.org> <20170314212701.GA8440@jasmine> <874lyv4jx7.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170314215913.GA13036@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnugB-0002iD-Uk for guix-devel@gnu.org; Tue, 14 Mar 2017 18:12:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnug8-0008Ve-7f for guix-devel@gnu.org; Tue, 14 Mar 2017 18:12:31 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36914) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnug7-0008Uy-TL for guix-devel@gnu.org; Tue, 14 Mar 2017 18:12:28 -0400 In-Reply-To: <20170314215913.GA13036@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Leo Famulari writes: > On Tue, Mar 14, 2017 at 10:39:48PM +0100, Marius Bakke wrote: >> Going forward, I wonder if there could be any unintended side effects by >> simply increasing the timeouts in nss/gtests/ssl_gtest/tls_connect.cc >> from 5000 ms to something like 20000. If a 0-day is discovered in "nss", >> we don't want to wait several days to get a successful build. > > If these failures seem to be timeout issues, I think we should try this. > We do have other packages that make similar changes. I'm currently building NSS (on x86_64) with timeouts increased from 5s to 25s. The recent armhf test failure took 22725ms, and when we struggled with 3.29.2 it took ~20000ms too. Patch attached. I *think* the two values are for client and server respectively, but will study the source and build logs some more to make sure we're adjusting the right knobs. I suggest we try this on 'core-updates' if the patch is correct. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-nss-Increase-test-timeouts.patch Content-Transfer-Encoding: quoted-printable From=20c8e0b85953133328e27f0bfcc9a9a0330e36ce5a Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Tue, 14 Mar 2017 22:54:41 +0100 Subject: [PATCH] gnu: nss: Increase test timeouts. * gnu/packages/patches/nss-increase-test-timeout.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/gnuzilla.scm (nss)[source]: Use it. =2D-- gnu/local.mk | 1 + gnu/packages/gnuzilla.scm | 3 ++- gnu/packages/patches/nss-increase-test-timeout.patch | 20 ++++++++++++++++= ++++ 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/nss-increase-test-timeout.patch diff --git a/gnu/local.mk b/gnu/local.mk index c1b076a5f..7fb22ebb5 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -780,6 +780,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/ninja-tests.patch \ %D%/packages/patches/ninja-zero-mtime.patch \ %D%/packages/patches/node-9077.patch \ + %D%/packages/patches/nss-increase-test-timeout.patch \ %D%/packages/patches/nss-pkgconfig.patch \ %D%/packages/patches/ntfs-3g-CVE-2017-0358.patch \ %D%/packages/patches/nvi-assume-preserve-path.patch \ diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index e6e24f665..1d84e7a9a 100644 =2D-- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -199,7 +199,8 @@ in the Mozilla clients.") (base32 "149807rmzb76hnh48rw4m9jw83iw0168njzchz0hmbsgc8mk0i5w")) ;; Create nss.pc and nss-config. =2D (patches (search-patches "nss-pkgconfig.patch")))) + (patches (search-patches "nss-pkgconfig.patch" + "nss-increase-test-timeout.patch"))= )) (build-system gnu-build-system) (outputs '("out" "bin")) (arguments diff --git a/gnu/packages/patches/nss-increase-test-timeout.patch b/gnu/pac= kages/patches/nss-increase-test-timeout.patch new file mode 100644 index 000000000..76d4853ba =2D-- /dev/null +++ b/gnu/packages/patches/nss-increase-test-timeout.patch @@ -0,0 +1,20 @@ +--- a/nss/gtests/ssl_gtest/tls_connect.cc 2017-03-14 22:47:30.855813629 +0= 100 ++++ b/nss/gtests/ssl_gtest/tls_connect.cc 2017-03-14 22:48:49.042335273 +0= 100 +@@ -245,7 +245,7 @@ +=20 + ASSERT_TRUE_WAIT((client_->state() !=3D TlsAgent::STATE_CONNECTING) && + (server_->state() !=3D TlsAgent::STATE_CONNECTING), +- 5000); ++ 25000); + } +=20 + void TlsConnectTestBase::EnableExtendedMasterSecret() { +@@ -387,7 +387,7 @@ + } else { + fail_agent =3D server_; + } +- ASSERT_TRUE_WAIT(fail_agent->state() =3D=3D TlsAgent::STATE_ERROR, 5000= ); ++ ASSERT_TRUE_WAIT(fail_agent->state() =3D=3D TlsAgent::STATE_ERROR, 2500= 0); + } +=20 + void TlsConnectTestBase::ConfigureVersion(uint16_t version) { =2D-=20 2.12.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljIaskACgkQoqBt8qM6 VPpRfQf/eWmS6n0Q8gKpIr4C5fm/d8Zfrf6w3lHTL6A/IfjdLcEV81odsXLn1rRZ zD6lDEJPccF3/XhqdPJK53eHmudJ7X/8PIKHxtLsjLyUkkmjsYPAvAyv9t71ak1P 6lAGItDPv6mbESnBf6kuzR9u30Bu/N+WQibAwWP8KbHZQSqLu+++DHsuT0y9FHwS NOd/Y9ZJK26byunCsy8bHZt/M3M4ReqZPuXbbF7nmQTpwzbJNakvUcT4QE0nHzWZ svVkavKmnsN7+fLDJ/mZjhQ7LLoZvYpLcea4wNCJDTwYB1XgXLEx9Xg6YUdqhELm GO3D0s6beMLyawiJY235s6MNNe5+lQ== =PhJf -----END PGP SIGNATURE----- --==-=-=--