From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option. Date: Thu, 16 Mar 2017 21:50:24 +0100 Message-ID: <87y3w5hrov.fsf@lassieur.org> References: <20170219185431.zgn53ndcbpedrgo7@wasp> <20170220235355.29115-1-clement@lassieur.org> <20170220235355.29115-5-clement@lassieur.org> <20170302084448.2ff6ce96@scratchpost.org> <87fuivxukg.fsf@lassieur.org> <20170305145026.zgoayn46kvpz5ksy@abyayala> <20170307214959.16038114@scratchpost.org> <87r3284x8s.fsf@lassieur.org> <87h92t1qts.fsf@gnu.org> <20170316204527.lnkgc2vot4uqk633@abyayala> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cocLw-0006Zp-5l for guix-devel@gnu.org; Thu, 16 Mar 2017 16:50:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cocLt-0004yH-28 for guix-devel@gnu.org; Thu, 16 Mar 2017 16:50:32 -0400 In-reply-to: <20170316204527.lnkgc2vot4uqk633@abyayala> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 writes: > Ludovic Courtès transcribed 1.1K bytes: >> Hi Clément, >> >> Clément Lassieur skribis: >> >> > I think there is a misunderstanding. I didn't want to push this because >> > it was not tested, and because subsystems are often useless without >> > Match, and Match is unsupported. The pair/list thing is not the >> > problem. >> > >> > And I was waiting for ng0 to test, because he asked for this patch (see >> > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so >> > I thought he was able to test. >> > >> > If ng0 still needs the patch and confirms that it works well, I'm >> > willing to update it. Otherwise, let's drop it. >> >> The patch looks like a useful addition. It would be sad to drop it, no? >> >> If you could add a test to (gnu tests ssh) that would be perfect, but >> otherwise it LGTM. Perhaps the default value for ‘subsystems’ should >> include internal-sftp though, as users probably expect sftp to just work. >> >> I don’t have any issue with using two-element lists; I think the syntax >> for pairs can be a bit confusing for newcomers to it’s probably better >> to avoid it in service configuration. >> >> Thanks, >> Ludo’. >> > > I'm taking a break currently and only deal with planing things or > documenting work and future Guix related work, so I won't test this in > the next 1 or 2 weeks. > I am fairly sure that sshfs still needs this. > > ps Clément: 'them'/'they' are pronouns if you don't know the gender and/or > prefered pronoun of a person :) Oh, I apologize.