From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Build-side code with non-ASCII failing to build on Hydra
Date: Fri, 21 Apr 2017 22:55:41 +0200
Message-ID: <87y3uta3aq.fsf@gnu.org>
References: <877f2e1chp.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44001)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1d1fam-0001dY-MR
	for guix-devel@gnu.org; Fri, 21 Apr 2017 16:55:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1d1faj-0006mf-Fk
	for guix-devel@gnu.org; Fri, 21 Apr 2017 16:55:48 -0400
In-Reply-To: <877f2e1chp.fsf@netris.org> (Mark H. Weaver's message of "Fri, 21
	Apr 2017 02:49:38 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> On the security-updates jobset on Hydra, I'm seeing several new build
> failures due to non-ASCII characters within build-side code being
> misread:
>
>   https://hydra.gnu.org/build/2003897
>   https://hydra.gnu.org/build/2001256
>   https://hydra.gnu.org/build/2013954
>   https://hydra.gnu.org/build/2006487
>   https://hydra.gnu.org/eval/109617?compare=3D109613#tabs-now-fail
>
> Has something changed recently that might explain this?

That=E2=80=99s surprising.  On current master, on my laptop, utf8proc fails
exactly as shown in <https://hydra.gnu.org/build/2003897>:

--8<---------------cut here---------------start------------->8---
starting phase `check-data'

[...]

In /gnu/store/a42pfdz8w5qxdkp6xz8783ydywmp0p8p-module-import/guix/build/uti=
ls.scm:
 612: 1 [#<procedure c303a0 at /gnu/store/a42pfdz8w5qxdkp6xz8783ydywmp0p8p-=
module-import/guix/build/utils.scm:608:23 (expr)> #]
In unknown file:
   ?: 0 [make-regexp "?" 1]

ERROR: In procedure make-regexp:
ERROR: In procedure make-regexp: Invalid preceding regular expression
--8<---------------cut here---------------end--------------->8---

Yet Hydra says it succeeded on =E2=80=98master=E2=80=99:

  https://hydra.gnu.org/job/gnu/master/utf8proc-2.1.0.x86_64-linux

Indeed, the latest one that succeeded on x86_64 also works for me:

  $ guix build /gnu/store/cxwa18q2sa69i08982rb0dd73lph2spz-utf8proc-2.1.0.d=
rv
  /gnu/store/mf2bby0nzzsq2x5m654g89yxd3l9h6v8-utf8proc-2.1.0

The one in current master is different:

  $ ./pre-inst-env guix build utf8proc -d --no-grafts
  /gnu/store/133cl1mzwa3dzy5s3ihr90qspp7l6g96-utf8proc-2.1.0.drv
  ludo@ribbon ~/src/guix$ git describe
  v0.12.0-3158-g285f63e80

The difference is that one of the builders is UTF-8-encoded whereas the
other is Latin-1:

  $ diffoscope "/gnu/store/msbh42cr1f48z6hc24h5v9vpl18l5hhz-utf8proc-2.1.0-=
guile-builder" "/gnu/store/r9y6fma06w4ghz00nws372iqxcszpv25-utf8proc-2.1.0-=
guile-builder"
  --- /gnu/store/msbh42cr1f48z6hc24h5v9vpl18l5hhz-utf8proc-2.1.0-guile-buil=
der
  +++ /gnu/store/r9y6fma06w4ghz00nws372iqxcszpv25-utf8proc-2.1.0-guile-buil=
der
  =E2=94=9C=E2=94=80=E2=94=80 encoding
  =E2=94=82 @@ -1 +1 @@
  =E2=94=82 -iso-8859-1
  =E2=94=82 +utf-8

This is fixed by commit 9231ef12f2a595b8f1e677dbe50cc499555302b6 in
=E2=80=98master=E2=80=99.

Thanks for the heads-up, and sorry for the breakage!

Ludo=E2=80=99.