From: Kei Kebreau <kei@openmailbox.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26737@debbugs.gnu.org
Subject: bug#26737: Making sure that comments can be made
Date: Tue, 30 May 2017 14:13:50 -0400 [thread overview]
Message-ID: <87y3temcv5.fsf@openmailbox.org> (raw)
In-Reply-To: <87inkkg9ns.fsf@fastmail.com> (Marius Bakke's message of "Sun, 28 May 2017 19:42:47 +0200")
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Can I commit this (note: I will enable the release build, which
>> optimizes for size)? And for games with both ncurses and SDL tiles
>> interfaces, should the two interfaces be separate outputs or separate
>> packages all together?
>
> Since there has been no feedback for a month, I think you can go ahead
> and commit it (see HACKING).
>
> I do find the s/<math.h>/<cmath> substitution a bit odd. Is there an
> upstream issue about it? I think we should do that in a phase instead,
> since it's apparently not a problem with other compilers(?).
>
Long story short, standards-compliant C++ code that needs
C-standard-compatibile functions uses either:
* <c[header]> and std namespace function names or
* <[header].h> and global namespace function names.
This program tries to mix and match these methods. While it may work
with other compilers, this code isn't guaranteed to work with the C++
standard. As a result, either <math.h> is replaced with <cmath> or
functions like std::pow are replaced with ::pow. I simply chose the former.
See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3797.pdf#section.D.5
> Different outputs is generally better than separate packages, but I
> guess it depends on the case.
I'll experiment with this some time soon, then.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-05-30 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 17:20 bug#26737: [PATCH] gnu: Add cataclysm-dda Kei Kebreau
2017-05-27 19:37 ` bug#26737: Making sure that comments can be made Kei Kebreau
2017-05-28 17:42 ` Marius Bakke
2017-05-30 18:13 ` Kei Kebreau [this message]
2017-06-03 23:15 ` bug#26737: Status: [PATCH] gnu: Add cataclysm-dda Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3temcv5.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=26737@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.