all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27521@debbugs.gnu.org
Subject: [bug#27521] [PATCH v5] build: Add iso9660 system image generator.
Date: Sun, 02 Jul 2017 22:09:28 +0200	[thread overview]
Message-ID: <87y3s64n47.fsf@gnu.org> (raw)
In-Reply-To: <20170702203706.43b1f0de@scratchpost.org> (Danny Milosavljevic's message of "Sun, 2 Jul 2017 20:37:06 +0200")

Heya,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

>> Let’s add #:key (volume-id "GuixSD") and then:
>> 
>>   "--" "-volid" (string-upcase volume-id)
>
> It will fail when booting from CD because GuixSD can't find the root fs.

I don’t understand.  What I suggest here is equivalent to what was in
the patch (“-volid GUIXSD”), except that it avoids hard-coding the
value; it’s purely cosmetic.

>> Since this doesn’t have much to do with VMs, what about adding these
>> things to (gnu system iso9660) and (gnu build iso9660)?
>
> I'd be fine with it but I think adding it to system-disk-image (as this patch does) is actually quite fitting - also, most of the stuff in there is not for VMs either.  There are comments all over system-disk-image how it makes sure not to set up the stuff for qemu but for real hardware.

Riiight.

>> We can also remove this ‘if’: it’s not natural for ‘qemu-image’ to
>> produce something that’s not a “QEMU image.”
>
> The patch context is misleading :)
>
> What it actually does is extend system-disk-image:
>
> (define (system-disk-image ... file-system-type)
>   ...
>   (if (= file-system-type "iso9660")
>       (iso9660-image ...)
>       (qemu-image)))

Oh OK, my bad.

> And if we want we could actually drop the entire non-iso9660 hydra image (after testing, of course) because the grub-mkrescue image will boot from usb stick as well.  So no need to have two different ones, actually.

You mean we could always use ‘grub-mkrescue’ instead of using it in one
case and using ‘grub-install’ & co. in the other case, right?

If that works, that sounds like a good idea to me.

>> Could you update “Invoking guix system” accordingly?
>
> We could replace the old "guix system disk-image" by a new "guix system disk-image" which always creates the iso9660 image.
>
> Or are there other use cases of "guix system disk-image" ?

“guix system disk-image” is documented as returning a raw disk image,
which I think can be useful to keep.

So what about having:

  guix system vm-image   # qcow2
  guix system disk-image # raw
  guix system iso-image  # iso9660

?

Alternately, we could of course do:

  guix system image -f FORMAT

where FORMAT is one of the above.

Thoughts?

Perhaps it’s simpler to just add “guix system iso-image” in this patch
series and to think about the other option separately.

Ludo’.

  reply	other threads:[~2017-07-02 20:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 22:03 [bug#27521] [PATCH] build: Add iso9660 system image generator Danny Milosavljevic
2017-06-28 22:22 ` [bug#27521] [PATCH v2] " Danny Milosavljevic
2017-06-28 22:48 ` [bug#27521] [PATCH v3] " Danny Milosavljevic
2017-06-29  2:09 ` [bug#27521] [PATCH v4] " Danny Milosavljevic
2017-06-29 13:47   ` [bug#27521] [PATCH v5] " Danny Milosavljevic
2017-06-30 10:13     ` Danny Milosavljevic
2017-07-02 14:55     ` Ludovic Courtès
2017-07-02 18:37       ` Danny Milosavljevic
2017-07-02 20:09         ` Ludovic Courtès [this message]
2017-07-02 22:01           ` Danny Milosavljevic
2017-07-03  7:38             ` Ludovic Courtès
2017-07-03 10:31               ` Danny Milosavljevic
2017-07-03 11:49                 ` Ludovic Courtès
2017-07-03 10:34               ` [bug#27521] [PATCH] guix system: Add "--file-system-type" option Danny Milosavljevic
2017-07-03 11:56                 ` Ludovic Courtès
2017-07-03 13:14                   ` Danny Milosavljevic
2017-07-03 14:17                     ` Ludovic Courtès
2017-07-03 14:20                       ` Danny Milosavljevic
2017-07-03 15:31                         ` Ludovic Courtès
2017-07-03 14:42                 ` Danny Milosavljevic
2017-07-03 11:10               ` [bug#27521] [PATCH] build: Allow specifying volume-uuid with make-iso9660-image Danny Milosavljevic
2017-07-03 11:58                 ` Ludovic Courtès
2017-06-29  3:17 ` [bug#27521] [PATCH] linux-initrd: Add isofs if necessary Danny Milosavljevic
2017-07-02 14:56   ` Ludovic Courtès
2017-07-02 18:28     ` Danny Milosavljevic
2017-07-03 18:02 ` [bug#27521] [PATCH] guix system: Add file system label and uuid to iso9660-image Danny Milosavljevic
2017-07-07 16:06   ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3s64n47.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=27521@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.