From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUvJj-0000eu-8w for guix-patches@gnu.org; Tue, 11 Jul 2017 09:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUvJe-0002C1-Ep for guix-patches@gnu.org; Tue, 11 Jul 2017 09:35:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUvJe-0002BO-AV for guix-patches@gnu.org; Tue, 11 Jul 2017 09:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUvJd-0001FX-UJ for guix-patches@gnu.org; Tue, 11 Jul 2017 09:35:01 -0400 Subject: [bug#27643] [PATCH] gnu: Add simplescreenrecorder. Resent-Message-ID: From: Alex Vong References: <87o9sse07d.fsf@gmail.com> Date: Tue, 11 Jul 2017 21:34:22 +0800 In-Reply-To: (Arun Isaac's message of "Tue, 11 Jul 2017 01:45:19 +0530") Message-ID: <87y3rvcd29.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 27643@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > Thanks for the patch! > >> + (inputs `(("pkg-config" ,pkg-config) > > pkg-config should be a native input. > I forget to run lint before submitting the patch... I have fixed this issue and other formatting issues reported by lint. >> + ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues >> + ("ffmpeg" ,ffmpeg) >> + ("alsa-lib" ,alsa-lib) >> + ("pulseaudio" ,pulseaudio) >> + ("jack" ,jack-1) >> + ("glu" ,glu) >> + ("libx11" ,libx11) >> + ("libxfixes" ,libxfixes) >> + ("libxext" ,libxext) > > The package builds successfully without libx11, libxfixes and libxext > included as inputs. Are you sure they are needed? Could you check again? > >> + ("libxi" ,libxi))) > These packages are listed as Build dependencies in README[0]. What do you think? > Also, could you sort all the inputs in alphabetical order, just for the > aesthetic appeal? :-) > >> + ;; Using HTTPS causes part of the page displayed improperly. >> + (home-page "http://www.maartenbaert.be/simplescreenrecorder/") > > We'll go with the HTTP URL for now. But, do report this issue upstream > as well. Yeah, I'll report it later. Thanks for the review! [0]: https://github.com/MaartenBaert/ssr --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdZDkzSn0Cycogr9IxYq4eRf1Ea4FAllk094ACgkQxYq4eRf1 Ea73SBAAs/yRKUDy7a7vusI7zUIQz7YFbFmodYLt2UAiVt3GIIMPvZXMUSSfGz1D 0COOhZwE/Fh8Z+oOvr72csby7crAbJaOspymYvWyS0GzQwcytXYt7j88mVwlZpCk vQTj2Oy9alnPW9xzYmKfuPOQ4vuscm7WRTGIUg23nL5hiQDSqzzz84ekvZ/If8qO atz2WDrGmTGI+20ip7k4o4YtEqHTGS6MHJ20uGxBAwkJW15NpiQN1VivYCRzQgz4 sx0YbxkGlxLXBRDQogu92AqTwgm72jO4cN6JcPyD1eJ7tWnLYZk6uLvNnNP/XFru rW/ZueYgL2bDhxSjYWNABlYqUJvN6lnxgmY0rwGDIZu2H8uiSNxy5YuzwRwKsQXA 1ESxVDSys22QHmBA/Ys9upQg1/N01cQaXKx3e4i2G59oeergffTqpu2iv3s2G8xS yV9RROz96/vQL5gvltEqO5/jdZYhfrNEudCJ+W7+cfpxiiI0mtClRxZviRgvaEze pSl2Yl9lcpQVDpCLKVNWhgsNCsl0A23nH4YN43d7KdQX8OlPBXBumwYNEh0Z+RnI SA8vHpnIocTXBBV11VPhR+MX7N01hPJp7/XSwct7iyLEFkX9ZPoWGw215RM8aGIe BZ87LEF6MvUYF4wCaTmxKUwGdWA2Tph/uWQ3iuS97N9ehFqbKHI= =mB2c -----END PGP SIGNATURE----- --=-=-=--