all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Jelle Licht <jlicht@fsfe.org>
Cc: 27852@debbugs.gnu.org
Subject: [bug#27852] [PATCH] gnu: node: Update to 8.2.1.
Date: Fri, 28 Jul 2017 21:40:17 +0200	[thread overview]
Message-ID: <87y3r8l59a.fsf@gnu.org> (raw)
In-Reply-To: <CAPsKtfJGB058Gz6vYwVnS_kW11bE36=rL_rGhwfdmGK-wq2kfg@mail.gmail.com> (Jelle Licht's message of "Thu, 27 Jul 2017 17:33:05 +0200")

Jelle Licht <jlicht@fsfe.org> skribis:

> From f88297638a82858dff61176f646cdc4ddca748cf Mon Sep 17 00:00:00 2001
> From: Jelle Licht <jlicht@fsfe.org>
> Date: Thu, 27 Jul 2017 17:11:08 +0200
> Subject: [PATCH] gnu: node: Update to 8.2.1.
>
> * gnu/packages/node.scm (node): Update to 8.2.1.
> (node)[arguments]: Removed broken linter test.

LGTM!

> -             ;; Having the build fail because of linter errors is insane!
> +             ;; Linting is no longer supported in the release tarball
>               (substitute* '("Makefile")
> -               (("	\\$\\(MAKE\\) jslint") "")
> -               (("	\\$\\(MAKE\\) cpplint\n") ""))
> +               (("	\\$\\(MAKE\\) lint") ""))

Maybe add a link to <https://github.com/nodejs/node/issues/14513> for
future reference?

Thanks,
Ludo’.

  reply	other threads:[~2017-07-28 19:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 15:33 [bug#27852] [PATCH] gnu: node: Update to 8.2.1 Jelle Licht
2017-07-28 19:40 ` Ludovic Courtès [this message]
2017-09-01 22:20   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3r8l59a.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=27852@debbugs.gnu.org \
    --cc=jlicht@fsfe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.