From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkJ8U-0003vx-9H for guix-patches@gnu.org; Tue, 22 Aug 2017 20:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkJ8Q-0004mz-AF for guix-patches@gnu.org; Tue, 22 Aug 2017 20:03:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dkJ8Q-0004mJ-3z for guix-patches@gnu.org; Tue, 22 Aug 2017 20:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dkJ8P-0005Gu-Il for guix-patches@gnu.org; Tue, 22 Aug 2017 20:03:01 -0400 Subject: [bug#27468] [PATCH] gnu: Add linkchecker. Resent-Message-ID: From: Marius Bakke In-Reply-To: <4cc366f5.AEMAO2lAou4AAAAAAAAAAAPNQHwAAAACwQwAAAAAAAW9WABZnL7F@mailjet.com> References: <7a5dc060.AEQAMFHLF6MAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZTa-9@mailjet.com> <4cc366f5.AEMAO2lAou4AAAAAAAAAAAPNQHwAAAACwQwAAAAAAAW9WABZnL7F@mailjet.com> Date: Wed, 23 Aug 2017 02:02:46 +0200 Message-ID: <87y3qb1789.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac , 27468@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > * gnu/packages/web.scm (linkchecker): New variable. [...] > + (modify-phases %standard-phases > + ;; Remove faulty python-requests version check. This has been fixed > + ;; upstream, and can be removed in version 9.4. > + (add-after 'unpack 'remove-python-requests-version > + (lambda _ > + (substitute* "linkcheck/__init__.py" > + (("requests.__version__ <= '2.2.0'") "False"))))))) Please end this phase on a #t since (substitute* ...) has an unspecified return value. > + (home-page "https://linkcheck.github.io/linkchecker/") > + (synopsis "Check websites for broken links") > + (description "LinkChecker is a website validator. It checks for broken > +links in websites. It is recursive and multithreaded providing output in > +colored or normal text, HTML, SQL, CSV, XML or as a sitemap graph. It > +supports checking HTTP/1.1, HTTPS, FTP, mailto, news, nntp, telnet and local > +file links.") > + (license (list l:gpl2+ > + l:bsd-2 ; linkcheck/better_exchook2.py > + l:bsd-3 ; linkcheck/colorama.py > + l:psfl ; linkcheck/gzip2.py > + l:expat ; linkcheck/mem.py > + l:isc ; third_party/dnspython > + l:asl2.0)))) ; third_party/miniboa Is it possible to remove these third party libraries and use packaged copies instead? At least 'dnspython' is already in Guix. Also, since GPL2+ is stricter than the other licenses, the program as a whole is effectively GPL2+, so we don't really need to mention those one-off source files in the license field (but comments are great). Not sure about the 3rd party bundles though, since they probably don't depend on anything from the GPL2+ distribution. If they are installed, I guess we should mention them with a FIXME. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmcxiYACgkQoqBt8qM6 VPqjNAf7B3d9d+KE/00Chcqqvq/VqDLUO/EQKtvgf/xEtDauK5VukEwXiJYSPqes Hrl5p1xfVB4DT1fOp+9qhbz8esbtQPKLDptvI1wv4Y+7LAI0hpdiNdr+h06OcsZl t6iZEFWIsDTbwIBuIdmUcSin2E9sd0pFlym2K3R8Px3c0N04o3nWqk37U27UTrXN iBnx2ct5ozpTvu3bUkNsG4u4f4f7mfnYV20o/YwWKLN4JQwx6npV/x33ha1+i2nP E63vg9Ch5eDMfwkY+DHkk5117tAb3nb8d3m3QB3shzugcfK8SOZEKqO9b8lEiRES h5nmGhxGP5A435A02sVPF1LsUnfkWA== =o635 -----END PGP SIGNATURE----- --=-=-=--