From: Marius Bakke <mbakke@fastmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>, 27468@debbugs.gnu.org
Subject: [bug#27468] [PATCH] gnu: Add linkchecker.
Date: Wed, 23 Aug 2017 02:02:46 +0200 [thread overview]
Message-ID: <87y3qb1789.fsf@fastmail.com> (raw)
In-Reply-To: <4cc366f5.AEMAO2lAou4AAAAAAAAAAAPNQHwAAAACwQwAAAAAAAW9WABZnL7F@mailjet.com>
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> * gnu/packages/web.scm (linkchecker): New variable.
[...]
> + (modify-phases %standard-phases
> + ;; Remove faulty python-requests version check. This has been fixed
> + ;; upstream, and can be removed in version 9.4.
> + (add-after 'unpack 'remove-python-requests-version
> + (lambda _
> + (substitute* "linkcheck/__init__.py"
> + (("requests.__version__ <= '2.2.0'") "False")))))))
Please end this phase on a #t since (substitute* ...) has an unspecified
return value.
> + (home-page "https://linkcheck.github.io/linkchecker/")
> + (synopsis "Check websites for broken links")
> + (description "LinkChecker is a website validator. It checks for broken
> +links in websites. It is recursive and multithreaded providing output in
> +colored or normal text, HTML, SQL, CSV, XML or as a sitemap graph. It
> +supports checking HTTP/1.1, HTTPS, FTP, mailto, news, nntp, telnet and local
> +file links.")
> + (license (list l:gpl2+
> + l:bsd-2 ; linkcheck/better_exchook2.py
> + l:bsd-3 ; linkcheck/colorama.py
> + l:psfl ; linkcheck/gzip2.py
> + l:expat ; linkcheck/mem.py
> + l:isc ; third_party/dnspython
> + l:asl2.0)))) ; third_party/miniboa
Is it possible to remove these third party libraries and use packaged
copies instead? At least 'dnspython' is already in Guix.
Also, since GPL2+ is stricter than the other licenses, the program as a
whole is effectively GPL2+, so we don't really need to mention those
one-off source files in the license field (but comments are great).
Not sure about the 3rd party bundles though, since they probably don't
depend on anything from the GPL2+ distribution. If they are installed,
I guess we should mention them with a FIXME.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-08-23 0:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 0:17 [bug#27468] [PATCH] gnu: Add linkchecker Arun Isaac
[not found] ` <handler.27468.B.149826350831000.ack@debbugs.gnu.org>
2017-06-24 0:27 ` [bug#27468] Acknowledgement ([PATCH] gnu: Add linkchecker.) Arun Isaac
2017-08-22 23:34 ` Arun Isaac
2017-08-23 0:10 ` Marius Bakke
2017-08-22 23:30 ` [bug#27468] [PATCH] gnu: Add linkchecker Arun Isaac
2017-08-23 0:02 ` Marius Bakke [this message]
2017-08-23 7:26 ` Arun Isaac
2017-08-23 7:33 ` Arun Isaac
[not found] ` <4a4f0a8d.AEEAPL4o3uEAAAAAAAAAAAPFd4cAAAACwQwAAAAAAAW9WABZnS4m@mailjet.com>
2017-08-24 17:43 ` Marius Bakke
2017-08-26 7:41 ` Arun Isaac
2017-08-30 7:29 ` bug#27468: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3qb1789.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=27468@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.