From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e5WW3-0006uc-Ls
	for guix-patches@gnu.org; Fri, 20 Oct 2017 08:35:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e5WVy-0000ej-AK
	for guix-patches@gnu.org; Fri, 20 Oct 2017 08:35:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42556)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e5WVy-0000ee-6Q
	for guix-patches@gnu.org; Fri, 20 Oct 2017 08:35:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e5WVx-0002Qi-RA
	for guix-patches@gnu.org; Fri, 20 Oct 2017 08:35:01 -0400
Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat.
Resent-Message-ID: <handler.28832.B28832.15085028829308@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87lgke3vlz.fsf@gmail.com>
	<20171014102915.11778-1-go.wigust@gmail.com>
Date: Fri, 20 Oct 2017 14:34:39 +0200
In-Reply-To: <20171014102915.11778-1-go.wigust@gmail.com> (Oleg Pykhalov's
	message of "Sat, 14 Oct 2017 13:29:13 +0300")
Message-ID: <87y3o6uheo.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 28832@debbugs.gnu.org

Hello,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-json-reformat): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'install 'check
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (zero? (system* "emacs" "--batch" "-L" "."
> +                             "-L" (string-append
> +                                   (assoc-ref inputs "emacs-undercover")
> +                                   "/share/emacs/site-lisp/guix.d/underc=
over-"
> +                                   ,(package-version emacs-undercover))
> +                             "-L" (string-append
> +                                   (assoc-ref inputs "emacs-dash")
> +                                   "/share/emacs/site-lisp/guix.d/dash-"
> +                                   ,(package-version emacs-dash))
> +                             "-L" (string-append
> +                                   (assoc-ref inputs "emacs-shut-up")
> +                                   "/share/emacs/site-lisp/guix.d/shut-u=
p-"
> +                                   ,(package-version emacs-shut-up))
> +                             "-l" "test/test-helper.el"
> +                             "-l" "test/json-reformat-test.el"
> +                             "-f" "ert-run-tests-batch-and-exit"))
> +             ;; Fails
> +             ;; json-reformat-test:json-reformat-region-occur-error
> +             ;; json-reformat-test:string-to-string
> +             #t)))))

Did you have a chance to investigate the test failures?  It=E2=80=99s not
confidence-inspiring ;-), so it would be good to at least have a link to
an upstream bug report.

Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80=99 d=
efine the
=E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to carry=
 all these -L flags?
Is there any downside?

Thanks,
Ludo=E2=80=99.