From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIhsn-00019s-NN for guix-patches@gnu.org; Sat, 25 Nov 2017 16:21:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIhsk-00016r-Ex for guix-patches@gnu.org; Sat, 25 Nov 2017 16:21:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:49594) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIhsk-00016A-2F for guix-patches@gnu.org; Sat, 25 Nov 2017 16:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eIhsj-0003lg-Pn for guix-patches@gnu.org; Sat, 25 Nov 2017 16:21:01 -0500 Subject: bug#29432: [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20171124210958.10089-1-kkebreau@posteo.net> <20171125001716.GC17061@jasmine.lan> <873752jlfr.fsf@posteo.net> <20171125175710.GA23396@jasmine.lan> Date: Sat, 25 Nov 2017 16:20:05 -0500 In-Reply-To: <20171125175710.GA23396@jasmine.lan> (Leo Famulari's message of "Sat, 25 Nov 2017 12:57:10 -0500") Message-ID: <87y3muhx8a.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 29432-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Sat, Nov 25, 2017 at 12:51:52PM -0500, Kei Kebreau wrote: >> Leo Famulari writes: >>=20 >> > On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote: >> >> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replac= e readelf >> >> substitution and add stat and getfacl substitutions. >> >> [inputs]: Add acl. >> > >> > Can you add an example of the error messages in the commit message? >> > Otherwise LGTM. >> > >>=20 >> Like this? >>=20 >> Errors fixed include the following: >> "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'" >> "diffoscope.comparators.directory: Unable to find 'getfacl', some >> directory metadata differences might not be noticed." >> "diffoscope.comparators.directory: Unable to find 'stat'" > > Sure! Pushed to master as 2af6be91d59ad5aefe01e90aa9045e26d8667098. Thank you for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAloZ3oYACgkQ5qXuPBlG eg1N2hAAgTzbCBUlarDkXxKxUpijBZPWWK6wUWmg4tZ0kv7H8PWXL3c62fQQrrCC CUwHTcC9/iY6f3PMFuNCz+gi1eBN8nfzzCIb4XBzxN9l71LFLTGCwa7tPK4B4CYL +T1/eoiMPo5B4TA5v7grK16M17x0uid/G36YcQ/DoMSqAgyDW8+1IfUBg7wTSRq0 8pbsHHzdTMTgS6jakb82QO2ifyPx9hAqgXX5TL2S7/JAtp1SjsI4F+KHGLWhiWSP Zc4A4hCVIAs7eBbJybbni1G4xva8g95gEYhF/PQ7E00OBe/9zPBeOwYNzhRZS4Vj 1mpE5Znxq2FbyrEDJPWzuxWYtKHpe46mP7d7hpV7TGYHc8kh6v1seeTkkEdXPdVl 70nHWGyV27oqa3/AQCMnGeZa3pWcJ6zDQxDPDgryetQ5HYLJO/c/TQ+Ceu5aiy3a 8GAAeHdG0raUfI63Rq87aogzk6juFpt2Z58OgIMuFY253pW1juw3cg8R2oemowRj D9AosWIrHGSCYX5xPexxVZXwI7ZhkjIpNDlNRufpWbEOuuJ0Ix8eSXYzcPAosXb4 nDm9HbcdurBCPw59oU6elxEh7XM81dHG9RskthCSTdeKcO+4ezflHCccNSgTOeuZ w+IwHMMuWzu85OBh4M+yXBUD6XZfrF+x1WAvHOp8/ulAAb57ShE= =kgdr -----END PGP SIGNATURE----- --=-=-=--