From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQlKc-0005Rr-G3
	for guix-patches@gnu.org; Sun, 17 Dec 2017 21:39:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQlKZ-00071T-0m
	for guix-patches@gnu.org; Sun, 17 Dec 2017 21:39:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:59062)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eQlKY-00070W-Sy
	for guix-patches@gnu.org; Sun, 17 Dec 2017 21:39:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQlKY-0005QL-JA
	for guix-patches@gnu.org; Sun, 17 Dec 2017 21:39:02 -0500
Subject: [bug#29359] [PATCH 06/31] gnu: Add java-hawtjni.
Resent-Message-ID: <handler.29359.B29359.151356472720828@debbugs.gnu.org>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-6-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171119175805.902-6-julien@lepiller.eu>
Date: Sun, 17 Dec 2017 23:51:38 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <87y3m1m0hx.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 29359@debbugs.gnu.org


Julien Lepiller <julien@lepiller.eu> writes:

> * gnu/packages/java.scm (java-hawtjni): New variable.
[=E2=80=A6]
> +    (arguments
> +     `(#:jar-name "hawtjni.jar"
> +       #:source-dir "hawtjni-generator/src/main/java:hawtjni-runtime/src=
/main/java"
> +       #:tests? #f; no tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'build-native
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (with-directory-excursion "hawtjni-generator/src/main/resou=
rces/"
> +               (system* "gcc" "-c" "hawtjni.c" "-o" "hawtjni.o"
> +                        "-fPIC" "-O2"
> +                        (string-append "-I" (assoc-ref inputs "jdk") "/i=
nclude/linux"))
> +               (system* "gcc" "-c" "hawtjni-callback.c" "-o" "hawtjni-ca=
llback.o"
> +                        "-fPIC" "-O2"
> +                        (string-append "-I" (assoc-ref inputs "jdk") "/i=
nclude/linux"))
> +               (zero? (system* "gcc" "-o" "libhawtjni.so" "-shared"
> +                               "hawtjni.o" "hawtjni-callback.o")))))

Please do this instead:

    (let ((jdk (assoc-ref inputs "jdk")))
      (and (zero? (system* "gcc" =E2=80=A6 jdk =E2=80=A6))
           (zero? (system* "gcc" =E2=80=A6 jdk =E2=80=A6))
           (zero? (system* "gcc" =E2=80=A6)))

> +    (description "HawtJNI is a code generator that produces the JNI code=
 needed
> +to implement java native methods.  It is based on the jnigen code genera=
tor
> +that is part of the SWT Tools project.")

Please capitalize =E2=80=9Cjava=E2=80=9D.

--=20
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net