From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYTGr-0002ds-H4
	for guix-patches@gnu.org; Mon, 08 Jan 2018 03:59:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYTGo-0005zV-CZ
	for guix-patches@gnu.org; Mon, 08 Jan 2018 03:59:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:59725)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eYTGo-0005z4-98
	for guix-patches@gnu.org; Mon, 08 Jan 2018 03:59:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYTGn-0006W6-Sc
	for guix-patches@gnu.org; Mon, 08 Jan 2018 03:59:01 -0500
Subject: [bug#30009] [PATCH 1/1] gnu: Add selene.
Resent-Message-ID: <handler.30009.B30009.151540189824994@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <MWHPR16MB00637E2542CE23FEB9078462921D0@MWHPR16MB0063.namprd16.prod.outlook.com>
	<MWHPR16MB006385C19091AD35AC967DE7921D0@MWHPR16MB0063.namprd16.prod.outlook.com>
Date: Mon, 08 Jan 2018 09:58:14 +0100
In-Reply-To: <MWHPR16MB006385C19091AD35AC967DE7921D0@MWHPR16MB0063.namprd16.prod.outlook.com>
	(Fis Trivial's message of "Sat, 6 Jan 2018 18:04:28 +0000")
Message-ID: <87y3l8k9qx.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Fis Trivial <ybbs.daans@hotmail.com>
Cc: "30009@debbugs.gnu.org" <30009@debbugs.gnu.org>

Hello,

Some mostly cosmetic suggestions, which hopefully answer your questions:

Fis Trivial <ybbs.daans@hotmail.com> skribis:

> * gnu/packages/lua.scm (selene): New public variable.

[...]

> +         (replace 'install
> +           (lambda _
> +             (let* ((output     (assoc-ref %outputs "out"))
> +                    (source     (assoc-ref %build-inputs "source"))
> +                    (includedir (string-append output "/include")))

Avoid the =E2=80=98%outputs=E2=80=99 and =E2=80=98%build-inputs=E2=80=99 gl=
obal variables by writing:

  (lambda* (#:key inputs outputs #:allow-other-keys)
    (let ((output (assoc-ref outputs "out")))
      =E2=80=A6))

> +         ;; The path of test files are hard coded.
> +         (replace 'check
> +           (lambda _

Likewise.

> +             (let* ((output (assoc-ref %output "out"))
> +                    (source (assoc-ref %build-inputs "source"))
> +                    (builddir   (getcwd))
> +                    (testdir    (string-append builddir "/test")))
> +               (and
> +                (copy-recursively
> +                 (string-append source "/test")
> +                 testdir)
> +                (system* "make")
> +                ;; To overcome the hardcoded test path
> +                (mkdir-p "runner")
> +                (copy-file "./test_runner" "./runner/test_runner")
> +                (chdir "./runner")
> +                (system* "./test_runner"))))))))

Here you can remove =E2=80=98and=E2=80=99 and use =E2=80=98invoke=E2=80=99 =
instead of =E2=80=98system*=E2=80=99
(=E2=80=98invoke=E2=80=99 throws an exception when execution fails.)

> +    (home-page "https://github.com/jeremyong/Selene")
> +    (synopsis "Lua C++11 bindings")
> +    (description
> +     "Selene is a simple C++11 friendly header-only binding to Lua.")

It=E2=80=99s a library to create Lua bindings, pretty much like Boost::Pyth=
on,
isn=E2=80=99t it?  Perhaps the description could clarify that somehow.

Otherwise LGTM.  Could you send an updated patch?

Thank you!

Ludo=E2=80=99.