From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed0vl-00057s-7K for guix-patches@gnu.org; Sat, 20 Jan 2018 16:44:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ed0vi-00063O-30 for guix-patches@gnu.org; Sat, 20 Jan 2018 16:44:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:56720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ed0vh-000636-Uf for guix-patches@gnu.org; Sat, 20 Jan 2018 16:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ed0vh-0000pn-OU for guix-patches@gnu.org; Sat, 20 Jan 2018 16:44:01 -0500 Subject: bug#29896: [PATCH] gnu: java-asm: Update to 6.0. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Chris Marusich References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> <87fu71ufxo.fsf@gmail.com> Date: Sat, 20 Jan 2018 13:43:06 -0800 In-Reply-To: ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Sat, 20 Jan 2018 10:08:04 +0100") Message-ID: <87y3ksw6j9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits , Ricardo Wurmus , Julien Lepiller Cc: 29896-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > Actually I am not sure, that bnd is used runtime. How could we check that? The only class in the java-asm source code that uses bnd seems to be ModuleInfoBndPlugin.java. I checked by grepping for imports that mentioned the string "bnd". This class is declared public, and it is included in the output JAR, so it is technically possible for code that depends on java-asm to use this class (and therefore java-aqute-bndlib) at runtime, even though there might also be code that depends on java-asm that does not use this class at runtime. So it seems reasonable to make it a propagated-input. The only downside is that java-aqute-bndlib is 125% larger than java-asm (1.8 MiB compared to 0.8 MiB). I've committed this patch as d0e9ded713e06790aad4992de7c26d075d18b86d, with the changes we agreed upon. I've also added a copyright line for both you and me gnu/packages/java.scm. Julien Lepiller writes: > There's a method to get references to a dependency in java: you can put > it in the MANIFEST.MF file as: > > Class-Path: /gnu/store/... > > It's a space-separated list of jar files that have to be added to the > classpath. This could be done in a phase that runs just before the > build phase, like the phase that adds a Main-Class. We've considered using this feature, but I don't know if anybody followed through and tried it out. Your help would be welcome! Prior discussions can be found here: https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00249.html https://lists.gnu.org/archive/html/guix-devel/2017-05/msg00019.html If you want to discuss this further, please start a new thread on guix-devel@gnu.org. Ricardo Wurmus writes: > Chris Marusich writes: > >> The installed software still won't >> work without additional work on the part of the user (e.g., the user >> needs to set the CLASSPATH when invoking java, or use java's -cp >> option), but for now at least making the input a propagated input will >> ensure that it gets installed alongside the package which at runtime >> requires it, which is better than nothing. > > This can be fixed by adding a search path specification for CLASSPATH to > the icedtea packages. I think that's a good idea! I'll follow up with a separate patch later, unless you beat me to it. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlpjt+oACgkQ3UCaFdgi Rp1A+BAAurchPfbdy6EnQiRhteJJAeuwSIuDmsLCItCgXOWOu+FXyr70uON6ZpIK PDjaZ354ZCoQ2xogaisQyS3HZpRAuPfrHEvCxXEY9rnODYfjHXjb+oAI9I1GGTdE vVr/J7+wZeJPPYdJCKoLRJZXkQI+8OmOfMLkwNebz9QBLV6ANC9t9jf1lO/Y6U44 dVXIUTjdgo0B6VOV54vzwEMmZBtiJWi0uYxHlVPMTU4rdaX2MYlVLZ5LxPOJAbxz SVsLkNyncorY5prAnx8amqpwsBxGBK/wGbNafTzzBk8745Tjb6Sf53m0czJIQ9zc X7jPVg0DNJQm7LiD6mzVPUb8a8yNO9Nb52xsh3d5p+ZTw0dxZ2HyrvpCrX2MvvBz /CW+fCuftB217zNFBaJyvAEk1YSOAmydYuFiIe0FxNJjb6xQK31KwAjvNbS+ZrwG ATNj1U6pDoAg6do3dwEf0y9wLLmcYIiQJnbZpiSc8NkBPsQ9o8GlHFaBAxYN1eZu 52xt/x9rv9yMtF9XkXJgYSH4EXEG9Djp6cbAeBcE9wg2wIELJSU9NE2U6lnEyr+Z El3PXz9JiG2nmlEOMn67EIjZkvK0IIvZ+tQw3ReIE90hqbRIJJs7SdXwwrBScnZr F93afhqbMyanYMoaKqdWfoigIPrDYSSPE2lHtWiP4hKPBjCazQ0= =72y3 -----END PGP SIGNATURE----- --=-=-=--