Leo Famulari <leo@famulari.name> writes:

> On Mon, Jan 22, 2018 at 09:08:21PM +0000, Christopher Baines wrote:
>> * gnu/packages/terminals.scm (go-golang.org-x-crypto-ssh-terminal): New
>>   variable.
>
>> +(define-public go-golang.org-x-crypto-ssh-terminal
>> +  (let ((commit "c78caca803c95773f48a844d3dcab04b9bc4d6dd")
>> +        (revision "0"))
>> +    (package
>> +      (name "go-golang.org-x-crypto-ssh-terminal")
>> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
>
> Can you use (git-version "0.0.0" revision commit) here?
>
>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://go.googlesource.com/crypto")
>> +                      (commit commit)))
>> +                (file-name (string-append "go.googlesource.com-crypto-"
>> +                                          version "-checkout"))
>
> And here, (git-file-name name version)?

Sure, those sound like useful helpers.