From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoreM-0002uw-QY for guix-patches@gnu.org; Thu, 22 Feb 2018 09:15:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoreI-0000ot-NS for guix-patches@gnu.org; Thu, 22 Feb 2018 09:15:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:47535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoreI-0000oZ-II for guix-patches@gnu.org; Thu, 22 Feb 2018 09:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eoreI-0007Uh-3O for guix-patches@gnu.org; Thu, 22 Feb 2018 09:15:02 -0500 Subject: [bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files). Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180128184437.32296-1-go.wigust@gmail.com> References: <20180128184437.32296-1-go.wigust@gmail.com> Date: Thu, 22 Feb 2018 15:14:44 +0100 Message-ID: <87y3jl9kmj.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov , 30274@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Oleg Pykhalov writes: > Hello Guix, > > Licensecheck attempts to determine the license that applies to each file > passed to it, by searching the start of the file for text belonging to va= rious > licenses. Nice! I've read through the series, and the only remark I have is that it's better to use 'perl-license' rather than (package-license perl) (see the comment in (guix licenses)). Probably won't be a problem any time soon, but still. Regarding the -2 variants, I assume other packages fail to build if they are simply updated? It would be good to have comments about it in the code. Apart from that LGTM, thank you! > Oleg Pykhalov (21): > gnu: Add perl-test-filename. > gnu: Add perl-path-iterator-rule. > gnu: Add perl-pod-constants. > gnu: Add perl-regexp-pattern. > gnu: Add perl-regexp-pattern-license. > gnu: Add perl-number-range. > gnu: Add perl-string-copyright. > gnu: Add perl-string-escape. > gnu: Add perl-test-failwarnings. > gnu: Add perl-data-section. > gnu: Add perl-software-license. > gnu: Add perl-extutils-depends. > gnu: Add perl-b-hooks-op-check. > gnu: Add perl-bareword-filehandles. > gnu: Add perl-indirect. > gnu: Add perl-lexical-sealrequirehints. > gnu: Add perl-multidimensional. > gnu: Add perl-test-roo. > gnu: Add perl-universal-require. > gnu: Add perl-strictures-2. > gnu: Add licensecheck. > > gnu/local.mk | 1 + > gnu/packages/license.scm | 158 ++++++++++++++++++++ > gnu/packages/perl-check.scm | 73 ++++++++++ > gnu/packages/perl.scm | 340 ++++++++++++++++++++++++++++++++++++++= ++++++ > 4 files changed, 572 insertions(+) > create mode 100644 gnu/packages/license.scm > > --=20 > 2.15.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqO0FQACgkQoqBt8qM6 VPq8qggAx/XiVzkcrL8chBFhJX8M7PO3knXtkM5UHxP6RibraU5n8R0vdFdtlDJL ZqYN0FWuscx1nPGkKn1MpujzFMYc82Z/IRBJ6THEpJsiDtRxV9PlFwtl2TMhvzpl 0AHRSwXQHhQa7fidcTZ1Z2GjDur51EX39KthRO+PzirILdxMVVQxsfM6wfuE3419 S5tuPDpvjLJd+tVoQHdS6TR6PygwIb90JSDl8EglGKgYsnyihy7ecfwNzVODEY6o s45oHQJTLYHgdwt/aKB+NcNIOWIIrJ80nHzXanj+LerO9keN+4ax38gxWijwXet/ 8X/uhKWpYaeX5rwADU9w59AsJVcPJQ== =mcqB -----END PGP SIGNATURE----- --=-=-=--