From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1etYkk-0006tC-NC
	for guix-patches@gnu.org; Wed, 07 Mar 2018 08:05:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1etYkg-0004Xq-Nr
	for guix-patches@gnu.org; Wed, 07 Mar 2018 08:05:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:40665)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1etYkg-0004Xk-K6
	for guix-patches@gnu.org; Wed, 07 Mar 2018 08:05:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1etYkg-0003C5-5O
	for guix-patches@gnu.org; Wed, 07 Mar 2018 08:05:02 -0500
Subject: [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK
	library.
Resent-Message-ID: <handler.30517.B30517.152042788512248@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180218195049.20339-1-kkebreau@posteo.net>
Date: Wed, 07 Mar 2018 14:04:33 +0100
In-Reply-To: <20180218195049.20339-1-kkebreau@posteo.net> (Kei Kebreau's
	message of "Sun, 18 Feb 2018 14:50:49 -0500")
Message-ID: <87y3j4rq8u.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 30517@debbugs.gnu.org

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate confi=
gure
> flag.
> ---
>  gnu/packages/music.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 3709f10d1..e88c9f21f 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.=
")
>                      (("add_subdirectory\\(resources/music\\)") ""))))))
>      (build-system cmake-build-system)
>      (arguments
> -     '(#:tests? #f)) ; no check target
> +     '(#:tests? #f ; no check target
> +       #:configure-flags '("-DCMAKE_CXX_FLAGS=3D-ljack")))

I=E2=80=99d suggest adding a comment as to why this is needed.

Then I think you can go ahead and push it.  If it fixes a use case for
you, that=E2=80=99s already an improvement.

Thanks,
Ludo=E2=80=99.