From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey7iv-0004f3-Cg for guix-patches@gnu.org; Mon, 19 Mar 2018 23:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey7is-0006E7-53 for guix-patches@gnu.org; Mon, 19 Mar 2018 23:14:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ey7is-0006Dr-1Z for guix-patches@gnu.org; Mon, 19 Mar 2018 23:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ey7ir-0001b1-PE for guix-patches@gnu.org; Mon, 19 Mar 2018 23:14:01 -0400 Subject: [bug#30572] [PATCH 1/7] gnu: bootstrap: Add trivial packages for bash, mkdir, tar, and xz. Resent-Message-ID: From: Chris Marusich References: <20180222102933.4978-1-cmmarusich@gmail.com> <20180315040915.5556-1-cmmarusich@gmail.com> <20180315040915.5556-2-cmmarusich@gmail.com> <20180316231651.6889c44a@scratchpost.org> Date: Tue, 20 Mar 2018 04:13:41 +0100 In-Reply-To: <20180316231651.6889c44a@scratchpost.org> (Danny Milosavljevic's message of "Fri, 16 Mar 2018 23:16:51 +0100") Message-ID: <87y3inwiai.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 30572@debbugs.gnu.org, Chris Marusich --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: >> +(define (bootstrap-binary program-name) > ... >> + (license gpl3+) > > I can't believe I'm nitpicking on this - but can we fish that out of the = package > > (search-bootstrap-binary program-name (%current-system)) > > using package-license ? At first I tried to do what you suggest, but then it occurred to me that this might create a loop in the module dependency graph. For example, if in the case of "bash" I use a form like (package-license bash) to obtain the actual license used by the canonical bash package, the (gnu packages bootstrap) module will now depend on the (gnu packages bash) module. I don't know how that will interact with the rest of Guix; it seems safer to just avoid adding that and accept this small discrepancy in the bootstrap packages. It is simpler. Note that the bootstrap binaries' licenses are not currently correctly surfaced in every place to begin with. For example, the license of the "bootstrap-binaries" package (i.e., the %bootstrap-coreutils&co) is defined to be gpl3+, even though it contains xz, which actually uses gpl2+ and lgpl2.1+. Since (I suspect) these packages are intended for internal use, and since the canonical versions of these packages do have correct sources, licenses, and so forth, I'm not so sure we need to be very concerned about minor discrepancies like this. ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Chris Marusich skribis: > >> * gnu/packages/bootstrap.scm (bootstrap-binary): New procedure. >> (%bootstrap-bash, %bootstrap-mkdir, %bootstrap-tar, %bootstrap-xz): >> Use it to create these new packages, and export them. > > For =E2=80=98guix pack --bootstrap=E2=80=99, I believe we could avoid def= ining these > packages and simply use =E2=80=98%bootstrap-coreutils&co=E2=80=99 when = =E2=80=98--bootstrap=E2=80=99 is > used. > > Would that work for you? I considered this. However, my understanding is that a network connection is required to build %bootstrap-coreutils&co. Would we want to use it in tests even if it requires a network connection? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlqwfGcACgkQ3UCaFdgi Rp1wDQ//fv3k9+LO1QuyOqAOEaFvm93l8BFoTvJ2MpJsC+oqwZ8ZY8b0cc+dVNTr PgChHmNPiEW9e05dSIUOmbKU1m4shWFwQ4/Vlb/AZb5UAwgvlAJtiOEXzhpcMYRp 2bh90vjo2XQpu0mNYzQmDLZXKqlVj1WPKGgzoIhzngQBFIt8Ll0yOLoFWRt/a/Aj 9PLeyZDnVADMIbeyH9hgv/OiD+Uh3BcodvnUGO4MeRy0pd/dsrPoC1+3f4qlNBYX HpUp3yYLIviWB0+gjOEDBPkowSDvNDugYaa6Opi6dLnX70zgzcDy69qM6+USaL20 LPJJks1mcw/0CfgO6WdnpH8osljxRYWZW82zSdHo2eCCk5M5sDNuDnk/BYh8MBGv TRnB7xSbxevxb74zMF0D9OYFfNvTZCxlhlVfZryQv+L3T9Abr4EmA2MXQT3gogLo I/+KTvQOddi+UQ2Pk1bEOnKMJKRHNyFS6vBbAyVR2WVm+pxqm0MsxY4kgXBwZNUp yeIzKXnYvj9XuhCaXj2HiocAltF78RDk3e+y7EfEqt3nJiivOukEJuwyCzafUsua xTRDrZi9bx0ZLbpYAyTstUjKXFEul21sH33lGhN6aUh5sbV+nRQ6tRiftYpSaixc ATo4nOdPhvx86Gsndfi6A37n9IPlePhVXjAv6RT2yAXhMNtw0PA= =Jml8 -----END PGP SIGNATURE----- --=-=-=--