From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyUwv-0003rH-UJ for guix-patches@gnu.org; Wed, 21 Mar 2018 00:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyUws-00032r-SK for guix-patches@gnu.org; Wed, 21 Mar 2018 00:02:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyUws-00032m-OE for guix-patches@gnu.org; Wed, 21 Mar 2018 00:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyUws-0006xE-Dp for guix-patches@gnu.org; Wed, 21 Mar 2018 00:02:02 -0400 Subject: [bug#30572] [PATCH 2/7] tests: Add tests for "guix pack". Resent-Message-ID: From: Chris Marusich References: <20180222102933.4978-1-cmmarusich@gmail.com> <20180315040915.5556-1-cmmarusich@gmail.com> <20180315040915.5556-3-cmmarusich@gmail.com> <20180316220732.19c2375a@scratchpost.org> <87a7v6pnmm.fsf@gnu.org> Date: Wed, 21 Mar 2018 05:00:53 +0100 In-Reply-To: <87a7v6pnmm.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 17 Mar 2018 19:23:29 +0100") Message-ID: <87y3im5b7u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30572@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Danny Milosavljevic skribis: > >>> +is_available () { >>> + # Use the "type" shell builtin to see if the program is on PATH. >>> + type "$1" >> >> Maybe >/dev/null ? Then it would only complain if it needed to. >> >>> +else >>> + echo "skipping pack verification because chroot or unshare is unav= ailable" >> >> echo "warning: Skipping pack verification because chroot or unshare is u= navailable" >&2 >> >> Otherwise LGTM! > > +1! > > Ludo'. Sure thing. I'll include this change when pushing to origin. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlqx2PUACgkQ3UCaFdgi Rp0PRBAAu2WNG+oLi8xuWCgC7cDqE6ezLKUK5h+2sFd0PQFKydP0hTIYRmTDlsmb Yc2qj8iafdOj88yXiTJSn29l+dUMM2/7wSkUPH1nS1hg0iZFgD2GgKb/pnXjcDix IHC7CaZtVBAQBBVnynIbBXQWOfYKkHfLizWwteEoQKKjgs2mfZ3hBakIXJ9kYctM t5bHamO4JdJ49jY2Bp2WU0hiW9eovmaBMv3ZGcJqAk6mbGpdZVZa2G7Xe/wGJSlC llgO2ZWYmcl8ToPcclT0VoIF2t+BQTfu7AnMqmPAGzWeBhzanS+NdabgoWY0qJFz WzHrz/bxVn62ccZdnagS93s5ZRxGgdS8sIbnNIJIT8XYCK1Dmku70mhzcz1rT3Yh U3R/mLlHCW3dZjToLo+EvxunPSPAcvvnqKDIzkh1oxqMqlqZ5PL0khra4tVfwUEW WhB9Jfy4fL5QiHp1vffPGCI1RNsVCSa14Re1gGbSNDUgfGwsP1tRBOtAb6Dej+QZ 6Mp3q64I+5E2Zc+tIswnv4kpOByBn7ge7RPCK7oNIZOkbAg84aikKwvKf1A6RXRF 5CVyMn1Bx0a2oEfmwZIBW7paB6EB4AFdlD+kHyL5vzjqtRzvgpAUPmQlS8jp2BiW jFTUB7NInIGEysXFabMZ/faSRdUC+/lUSHScCYYlaocB4a+3Y0Y= =+c9S -----END PGP SIGNATURE----- --=-=-=--