From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2HxH-0001qP-0j for guix-patches@gnu.org; Sat, 31 Mar 2018 10:58:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2HxD-0006L1-41 for guix-patches@gnu.org; Sat, 31 Mar 2018 10:58:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53415) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2HxC-0006K0-O6 for guix-patches@gnu.org; Sat, 31 Mar 2018 10:58:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f2HxC-0003iD-E8 for guix-patches@gnu.org; Sat, 31 Mar 2018 10:58:02 -0400 Subject: [bug#30259] [PATCH] gnu: octave: Add audio and Qt GUI support. Resent-Message-ID: From: Kei Kebreau References: <20180126151311.9049-1-kkebreau@posteo.net> <87wp04fpjs.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87po5wfmui.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87372scat2.fsf@posteo.net> <877es3zmla.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87y3kjatrn.fsf@posteo.net> <87607mn846.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <20180317152552.eui5w7e275sx4ohu@abyayala> Date: Sat, 31 Mar 2018 10:57:28 -0400 In-Reply-To: <20180317152552.eui5w7e275sx4ohu@abyayala> (ng0@n0.is's message of "Sat, 17 Mar 2018 15:25:52 +0000") Message-ID: <87y3i870o7.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 30259@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0 writes: > ng0@n0.is transcribed 2.4K bytes: >> On Sat, 27 Jan 2018, Kei Kebreau wrote: >> > ng0+guixpatches@n0.is writes: >> > >> >> On Fri, 26 Jan 2018, Kei Kebreau wrote: >> >>> ng0+guixpatches@n0.is writes: >> >>> >> >>>> On Fri, 26 Jan 2018, ng0+guixpatches@n0.is wrote: >> >>>>> On Fri, 26 Jan 2018, Kei Kebreau wrote: >> >>>>>> * gnu/packages/maths.scm (octave)[inputs]: Add qscintilla, >> >>>>>> qt, suitesparse, >> >>>>>> libsndfile, portaudio and alsa-lib. >> >>>>>> [native-inputs]: Add qttools. >> >>>>>> [arguments]: Add 'patch-qscintilla-library-name' phase. >> >>>>> >> >>>>> Woo! Nice :) I've started work on the Qt GUI a while ago but >> >>>>> never finished it. Do you think we should split this into octave >> >>>>> and octave-qt (or octave-gui)? Qt is quiet huge and not everyone >> >>>>> will want this I think. >> >>>>> >> >>>>> Building this now and getting back to you with results. >> >>>>> >> >> [=E2=80=A6] >> >>>> Build, compiled, installed, LGTM and works for me. At least the >> >>>> minimal basics I've tested. >> >>>> >> >>> >> >>> Excellent! Thanks for testing this. >> >>> >> >>>> However I still think we should split it later on. I'm not sure >> >>>> if other systems just provide it in one piece or if they provide >> >>>> octave-cli, octave-qt, etc. >> >>>> In my scenario we don't have substitutes for Qt all the time and >> >>>> someone running a >> >>>> machine which isn't capable of building Qt wants to use octave. >> >>> >> >>> I agree that this package should be split. Should a split be made now >> >>> while we leave the lighter CLI-only Octave package available on mast= er, >> >>> or should it be postponed until later on? >> >>> >> >> >> >> It could be done later on, but if you think it wouldn't be too >> >> much work you could do it now. >> > >> > Done, I think! >> > >> >> Ideally this would leave 'octave' as it is and add >> >> 'octave-whatever' ... octave-qt? Debian calls the package (with >> >> just the Qt Gui) "qtoctave". octave-* should be reserved for >> >> extensions (which we don't have right now), so maybe qtoctave >> >> would fit into our naming scheme? >> >> >> >> >> >> / I think I'm going to switch the subscribed address once more, >> >> now that I have proper filtering I don't need the server-side >> >> filtering. / >> > >> > Can you (and/or any bystanders reading this) test these? >> > >> > >> > >>=20 >> LGTM. >>=20 >> qtoctave worked, the normal octave should be alright. >>=20 >> Thank you very much for the work on this. > > Can someone push this? If nothing changed since the review I did, it's > good to go and just catching digital dust. Patch still applies iirc as > I build my active branch with it. Sorry for the delay! I've been swamped with other work. I'll be pushing this today as soon as I build and lint it on my computer. Thanks for your help! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlq/odgACgkQ5qXuPBlG eg2PCg/9FDoF+U9qK21AMVnqn66b5b0o5lZacr+gzMvkSMlyxb7fEUwSW+vJYBCQ 1I+ZBQ7KADu+LkLe5PZFzS9Hpp5G6neW1tBinxx+A3acBYKUFGISBtdqb6IQyGpf SnXoh71EC+agkayutr6QvWNkwnDmv4XXuv/AGj/36NAkRWWQvlzxEFr5iGoso+O6 Xtm+M1L291ZCsGuR7wwfjcwzQVL3Rum6au6Qn4cD/2OKODc75iru/hEsnRr8NiNL NTjvpWz4xUdk2iQFlbnuuT0EIP47mkOsUqB5gxjbPnoPxPqhW12zupke8jLxn1us 2Kt43a/+HNniGcCMtl8q1pgZpvuInYZYc0Y/BIMGYFqTEREooYTqncv0oVyeLH0I 3F/6nb7U58/cy/XUd3VMM43vbmJcUXL/5X7drr7h2uk91MefQ7Veio1Q87Q8Ln4y KShU+4yAtG59ePxdGiHrrojU1KgQ1POn7JV2KVMIwGHDKSX2qjqcvf0sz9N3KZnO hznR3rMZICpLD8WJeACSnF21qbEjD3MtppMgTGZd+x1Y6ElOZ5fHb6foR+rZ5GgD gKs6OFELx7mt5sEM6rFJxL7pq6Vlr4nZrROa6ZyRaMHiZckBYWomnzqhURK9GPqR NYXR6aFo+JDLXN7OHJgYxUvdUgYI4W3M/nXw0IyJHTQ+96ammx4= =TzYI -----END PGP SIGNATURE----- --=-=-=--