all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Sahithi Yarlagadda <sahi@swecha.net>
Cc: 30983-done@debbugs.gnu.org
Subject: bug#30983: Acknowledgement (Submitting Patch for gnu: r-abc-data)
Date: Mon, 02 Apr 2018 23:17:06 +0200	[thread overview]
Message-ID: <87y3i5cnql.fsf@elephly.net> (raw)
In-Reply-To: <c87b400e-f265-e62e-e609-04611bb0c691@swecha.net>


Hi Sahithi,

thank you for the patch.

> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 6f85f0d80..8602a7d87 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -2540,14 +2540,14 @@ supports arbitrary vertex/edge/graph attributes.")
>      (name "r-statnet-common")
>      (version "4.0.0")
>      (source
> -      (origin
> -        (method url-fetch)
> -        (uri (cran-uri "statnet.common" version))
> -        (sha256
> -          (base32
> -            "0yw6l5b4qv0jqlg4zyczas7m12a5pyqghs6ydxy2f6v6vxkijvi0"))))
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "statnet.common" version))
> +       (sha256
> +        (base32
> +         "0yw6l5b4qv0jqlg4zyczas7m12a5pyqghs6ydxy2f6v6vxkijvi0"))))
>      (properties
> -      `((upstream-name . "statnet.common")))
> +     `((upstream-name . "statnet.common")))
>      (build-system r-build-system)
>      (home-page "http://www.statnet.org")
>      (synopsis "R scripts and utilities used by the Statnet software")

These changes don’t belong to the addition of r-abc-data, so they should
not be included.  I have removed these changes before applying the
patch.

> @@ -3571,3 +3571,25 @@ and Eclat.")
>  time formats, @code{parse_date} parses dates in unspecified formats,
>  and @code{format_iso_8601} formats a date in ISO 8601 format.")
>      (license license:gpl2)))
> +
> +(define-public r-abc-data
> +  (package
> +    (name "r-abc-data")
> +    (version "1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "abc.data" version))
> +       (sha256
> +        (base32
> +         "1bv1n68ah714ws58cf285n2s2v5vn7382lfjca4jxph57lyg8hmj"))))
> +    (properties `((upstream-name . "abc.data")))
> +    (build-system r-build-system)
> +    (home-page "https://cran.r-project.org/web/packages/abc.data")
> +    (synopsis "Data Only: Tools for Approximate Bayesian Computation (ABC)")
> +    (description
> +     "Contains data […]

Please always use complete sentences.  I’ve changed this to “This
package contains …”

> +    (license license:gpl3)))

According to the home page, the license is actually GPLv3 or later, so I
changed this to license:gpl3+.

I have pushed this to the master branch with commit 2a27c0bbb.  Thanks
again!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

      reply	other threads:[~2018-04-02 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 11:16 [bug#30983] Submitting Patch for gnu: r-abc-data Sahithi Yarlagadda
     [not found] ` <handler.30983.B.152232227619573.ack@debbugs.gnu.org>
2018-03-29 11:21   ` [bug#30983] Acknowledgement (Submitting Patch for gnu: r-abc-data) Sahithi Yarlagadda
2018-04-02 21:17     ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3i5cnql.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=30983-done@debbugs.gnu.org \
    --cc=sahi@swecha.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.