From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Bp8-0000HT-O6 for guix-patches@gnu.org; Mon, 16 Apr 2018 17:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8Bp3-0000q7-Tn for guix-patches@gnu.org; Mon, 16 Apr 2018 17:38:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48412) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8Bp3-0000pv-QQ for guix-patches@gnu.org; Mon, 16 Apr 2018 17:38:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8Bp3-0007lx-Jl for guix-patches@gnu.org; Mon, 16 Apr 2018 17:38:01 -0400 Subject: [bug#31121] [PATCH 1/3] gnu: Add python2-urlgrabber Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180410092425.5560-1-sleep_walker@gnu.org> References: <20180410092425.5560-1-sleep_walker@gnu.org> Date: Mon, 16 Apr 2018 23:36:56 +0200 Message-ID: <87y3hmde9z.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= , 31121@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tom=C3=A1=C5=A1 =C4=8Cech writes: > * gnu/packages/python.scm (python2-urlgrabber): New variable. There is a 'python-web' module as well, would that be a good fit for this package? python.scm had to be split up since it was causing problems for the Guile compiler. [...] > +(define-public python2-urlgrabber > + (package > + (name "python2-urlgrabber") > + (version "3.10.2") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "urlgrabber" version)) > + (sha256 > + (base32 > + "0w1h7hlsq406bxfy2pn4i9bd003bwl0q9b7p03z3g6yl0d21ddq5")))) > + (build-system python-build-system) > + (arguments > + `(#:python ,python-2)) If Python 3 is unsupported, please add a comment about it. Otherwise it's better to add a Python 3 variant and make the Py2 variant inherit from it. > + (home-page "http://urlgrabber.baseurl.org") > + (synopsis "A high-level cross protocol url-grabber") Synopses should not start with an article (I believe `guix lint` will warn about this). Simply "High-level cross-protocol URL grabber". > + (description "URL grabber library unifying http://, ftp:// and file:= // > +protocols access, supporting HTTP keepalive, reget, throttling and other > +convenience features.") Please turn this into one or more complete sentences. E.g. "@code{urlgrabber} is a Python library that unifies access to ... It supports bla bla.". > + (license license:lgpl2.1))) This should be LGPL2.1+ as mentioned in the code headers. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlrVF3gACgkQoqBt8qM6 VPpEggf/W/+f9ZwOXN3jeCo5SXO+sib0wEE7hkeLfZiqwXlGDTYwtY8gwF2Ykx2O EsI3Xe4XDwiL0No/pWSu4jJhtQNbhsggz6nB6R2clUaWkrvb39ew/AIV0Nhf2AG3 Uub73StAeS3U01MUlvCFnNaYji6XcA07CkPxbsK9p2gC43A0fLNSJVsN4CqN4JxI OmOxL+Zh9UzDM3qWYO+lrZMhbCZ+GO6SBfxAgUBTVypGM/QmSM/JVnDjZ3B8UPWP Y9vuTzob9VMdRWo0TM++lSgz1WklDkqqgaExnRozMChOyE17QBMRyfDVFBOgFC86 cEaMG3uGOaHCve86REQO4iUpLycmIQ== =Lc7g -----END PGP SIGNATURE----- --=-=-=--