From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fIDBx-0000OR-3B
	for guix-patches@gnu.org; Mon, 14 May 2018 09:07:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fIDBt-0007A3-Un
	for guix-patches@gnu.org; Mon, 14 May 2018 09:07:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53727)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fIDBt-00079x-Rs
	for guix-patches@gnu.org; Mon, 14 May 2018 09:07:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fIDBt-0001Bc-IO
	for guix-patches@gnu.org; Mon, 14 May 2018 09:07:01 -0400
Subject: [bug#31449] [PATCH 2/3] gnu: Add jupyter-guile-kernel.
Resent-Message-ID: <handler.31449.B31449.15263031984531@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180514090751.1021-1-pierre-antoine.rouby@inria.fr>
	<20180514091014.1072-1-pierre-antoine.rouby@inria.fr>
Date: Mon, 14 May 2018 15:06:23 +0200
In-Reply-To: <20180514091014.1072-1-pierre-antoine.rouby@inria.fr> (Rouby
	Pierre-Antoine's message of "Mon, 14 May 2018 11:10:14 +0200")
Message-ID: <87y3gm75f4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr>
Cc: 31449@debbugs.gnu.org

Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr> skribis:

> * gnu/package/guile.scm (jupyter-guile-kernel): New variable.

[...]

> +                (scm-files '("hmac.scm"
> +                             "tools.scm"
> +                             "main.scm"))

Maybe (find-files "." "\\.scm$") would work?

> +                (guile-env    (if (not (eq? (getenv "GUILE_LOAD_PATH")
> +                                            #f))
> +                                  (string-append
> +                                   (getenv "GUILE_LOAD_PATH") ":")
> +                                  ""))
> +                (guile-go-env (if (not (eq? (getenv "GUILE_LOAD_COMPILED=
_PATH")
> +                                            #f))
> +                                  (string-append
> +                                   (getenv "GUILE_LOAD_COMPILED_PATH") "=
:")
> +                                  "")))

(not (eq? foo #f)) can be simplified to (not foo).

Also (getenv "GUILE_LOAD_PATH") and (getenv "GUILE_LOAD_COMPILED_PATH")
are always true in this case, I think, so perhaps you can remove these
two variables altogether?

> +           ;; Sed kernel file
> +           (substitute* (string-append kernel-dir "/"
> +                                       kernel-file)
> +             (("/home/jerry/.local/share/jupyter/kernels/guile/main.scm")
> +              (string-append module-dir "/main.scm")))

Maybe the comment could be, IIUC:

  ;; Fix hard-coded file name in the kernel.

> +    (synopsis "Guile kernel for jupyter")
                                   ^
=E2=80=9CGuile kernel for the Jupyter Notebook=E2=80=9D

> +    (description
> +     "This package is Guile kernel for Jupyter Notebook.  This software =
is
> +write for GNU Guile 2.0.")

What about:

  =E2=80=9CThis package provides a Guile 2.x kernel for the Jupyter Noteboo=
k.
  It allows users to interact with the Guile REPL through Jupyter.=E2=80=9D

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.