From: Mark H Weaver <mhw@netris.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 31647@debbugs.gnu.org
Subject: bug#31647: [core-updates] gtkglext fails in a weird way
Date: Wed, 30 May 2018 04:27:56 -0400 [thread overview]
Message-ID: <87y3g1a6pf.fsf@netris.org> (raw)
In-Reply-To: <874lipr612.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Wed, 30 May 2018 08:50:33 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
> Mark H Weaver <mhw@netris.org> writes:
>
>> In summary, although the new messages don't look as nice in common
>> cases, I think it's more important to ensure that we have the
>> information we need to debug the occasional non-obvious problem. So, I
>> think we should leave it alone :)
>
> I think we should strive to make the common case look good. Can we
> achieve this without making the exceptional case harder to debug? Can
> we caught the exception triggered by standard build phase invocations of
> “make” but not those of custom “invoke” expressions in custom build
> phases where the error message could be useful?
I appreciate your perspective on this, and you've made some good points.
How about this idea: in core-updates-next, we could add code to
'gnu-build' in (guix build gnu-build-system) which catches &invoke-error
exceptions thrown by the phase procedures. This is a very common case,
and I agree with you that a backtrace is rarely (if ever) useful for
that particular exception type. The program name and arguments included
in the condition object should be enough information. We could use a
copy of the code from (guix ui) to print the invoke errors nicely:
((invoke-error? c)
(leave (G_ "program exited\
~@[ with non-zero exit status ~a~]\
~@[ terminated by signal ~a~]\
~@[ stopped by signal ~a~]: ~s~%")
(invoke-error-exit-status c)
(invoke-error-term-signal c)
(invoke-error-stop-signal c)
(cons (invoke-error-program c)
(invoke-error-arguments c))))
However, I would prefer to catch *only* invoke errors, and to let most
exception types go unhandled by gnu-build. If you can think of another
exception type that should be handled more gracefully, please let me
know.
What do you think?
Mark
next prev parent reply other threads:[~2018-05-30 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 18:20 bug#31647: [core-updates] gtkglext fails in a weird way Ricardo Wurmus
2018-05-29 20:30 ` Ricardo Wurmus
2018-05-30 3:56 ` Mark H Weaver
2018-05-30 6:50 ` Ricardo Wurmus
2018-05-30 8:27 ` Mark H Weaver [this message]
2018-05-30 8:43 ` Mark H Weaver
2018-05-31 6:42 ` Ricardo Wurmus
2018-06-03 20:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3g1a6pf.fsf@netris.org \
--to=mhw@netris.org \
--cc=31647@debbugs.gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.