From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkBfN-000658-QT for guix-patches@gnu.org; Mon, 30 Jul 2018 13:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkBfK-0003IZ-US for guix-patches@gnu.org; Mon, 30 Jul 2018 13:09:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkBfK-0003IS-Q9 for guix-patches@gnu.org; Mon, 30 Jul 2018 13:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fkBfK-00086B-HI for guix-patches@gnu.org; Mon, 30 Jul 2018 13:09:02 -0400 Subject: [bug#32268] [PATCH] gnu: Add net-snmp. Resent-Message-ID: From: Oleg Pykhalov References: <20180725114434.21463-1-go.wigust@gmail.com> <871sbl4s3d.fsf@fastmail.com> Date: Mon, 30 Jul 2018 20:08:31 +0300 In-Reply-To: <871sbl4s3d.fsf@fastmail.com> (Marius Bakke's message of "Mon, 30 Jul 2018 00:03:50 +0200") Message-ID: <87y3dswt0w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 32268@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Marius, First of all thank you for your work on =E2=80=98net-snmp=E2=80=99. Marius Bakke writes: > Oleg Pykhalov writes: > >> * gnu/packages/networking.scm (net-snmp): New variable. > > Hello! This patch reminded me I had an ancient patch for Net-SNMP too, > but got stuck on a single test failure and forgot all about it. Oh, unfortunate I didn't find it before #32268. > I see you've disabled tests altogether which is a neat workaround. > However I'm hoping we can consolidate our efforts and just disable the > one (or was it two) tests that are failing. I did't find tests suite while packaging. Thank you for pointing that. > Comments inline, my patch attached at the end. > >> --- >> gnu/packages/networking.scm | 76 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 76 insertions(+) > > I chose to add a (gnu packages snmp) module, but that may be overkill > indeed. If you think about adding other SNMP specific tools then it's a great idea. :-) Maybe a =E2=80=98(gnu packages monitoring)=E2=80=99 module could= be also in a consideration? I vote for =E2=80=98(gnu packages networking)=E2=80=99 stil= l. [=E2=80=A6] > I opted to use the 5.8 pre-release instead. No strong opinion, but > since it's a new package and 5.8 is "just around the corner" I think > that's fine. WDYT? Wow, indeed. Seems I found a 5.8 release. Maybe we should peek it? WDYT? https://sourceforge.net/projects/net-snmp/files/net-snmp/5.8/ > Also note that this packages bundles a copy of OpenSSL, which should be > purged. > >> + (build-system gnu-build-system) >> + (native-inputs >> + `(("autoconf" ,autoconf) >> + ("automake" ,automake) >> + ("libtool" ,libtool))) > > Why are these needed? Because of the patches? The =E2=80=98(invoke "autoreconf" "-vfi")=E2=80=99 requires all those three= packages. >> + (inputs >> + `(("file" ,file) >> + ("perl" ,perl) >> + ("openssl" ,openssl))) > > "file" is an implicit input. Can you add a comment about why it's > needed here (I guess it's referenced somewhere?)? Configuration or complation phases failed without it. I don't see =E2=80=98file=E2=80=99 in your patch. So, I think I could skip commenting = above. :-) [=E2=80=A6] >> + (license license:bsd-3))) > > The main license is actually CMU/UCDs "Historic Permission Notice and > Disclaimer", which is not in Guix. Do you think it's worth adding, or > should we simply use a non-copyleft style URI here? Either way is OK for me, but I vote for non-copyleft style. Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAltfRg8ACgkQckbhHGm3 lWlVoRAApnN7MIjojDz2SzOq/xVXBN2RyDFG3Od0HKO8aZFNKS3tlN7r+BInhqSE /blYOkjHRPKQ/cWzc1Tps7eU5PECLz0Vlqh9U07vTRvxs71fZYQpgNtUxrE3XK60 Zjzhl8xjDRFpihNhOZA4S2sUnwGEXyesBPKbZkhCdPp+uooqivT1w5raK0NEyquJ h8aoVCjH7zPZdOXJ5nVLzNmVbsuPHrt/m0ZyM+VujgGNiHEe9c6pYZwL1goXmkHa zi0Vu6aPJ9R5DTdGgqxtLbzho6Kcquq35T36dfn5QVK2hzw9sL1A564P+WS1RsMv KNonwwcgIfdOSSBn9GUBMEFErzCwTD65VlKh3jadu+6S2tlwEZJB/QYhd77GquQu fveeAyzecqJRyQlwzjuzjHUmggOmpZpgcM76L1lvGC++iu+7+lTC5WGvSSxY+qvc bqN2rPPBM6eli5A38n06S0zwkmCMtDVvGiTVH+LMDDKzFbhrZfXvzTvgge6ZkES0 u58vB/NmLF+Qv6tQQlWaCeW0SWMXm/hRTqCAveH7r1fc7Dnp9lf3xzyY4/QTzkyG DcPjnPyiQLdqM10WWaKntYJN80HnvFNNoO17yHvTk3PgouIibnwjIsO8ZWxHAS8b fTxuz3z5p3AmcMo8rOnIHmZZclsxqoKT9Z78/K0VSbyR6UXr0CI= =x7c/ -----END PGP SIGNATURE----- --=-=-=--