From: Oleg Pykhalov <go.wigust@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 32386-done@debbugs.gnu.org
Subject: bug#32386: [PATCH] gnu: Add ubridge.
Date: Wed, 08 Aug 2018 02:50:42 +0300 [thread overview]
Message-ID: <87y3dhg2i5.fsf@gmail.com> (raw)
In-Reply-To: <20180807205857.GA10173@jasmine.lan> (Leo Famulari's message of "Tue, 7 Aug 2018 16:58:57 -0400")
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
Hello Leo,
Thank you for review.
Leo Famulari <leo@famulari.name> writes:
> On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/networking.scm (ubridge): New variable.
>> + (add-before 'build 'set-env-cc
>> + (lambda _
>> + (setenv "CC" "gcc")
>> + #t))
>
> Would it work to set this in #:make-flags? I think that's a little
> clearer.
Indeed, I forgot about ‘#:make-flags’, thank you.
>> + (description "uBridge is a simple program to create user-land bridges
>> +between various technologies. Currently bridging between UDP tunnels,
>> +Ethernet and TAP interfaces is supported. Packet capture is also supported.")
>
> Please add a comma in the second sentence: "Currently, bridging between
> UDP tunnels, Ethernet, and TAP interfaces is supported."
OK.
Pushed as 277f25ce5af060e2a057f5f43eeea2ae6f4fc5b9
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2018-08-08 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 8:38 [bug#32386] [PATCH] gnu: Add ubridge Oleg Pykhalov
2018-08-07 20:58 ` Leo Famulari
2018-08-07 23:50 ` Oleg Pykhalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3dhg2i5.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=32386-done@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.