all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: bootstrap: i686-linux now builds without binutils, gcc seeds
Date: Tue, 18 Sep 2018 22:53:07 +0200	[thread overview]
Message-ID: <87y3by1qa4.fsf@gnu.org> (raw)
In-Reply-To: <8736u752k6.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Mon, 17 Sep 2018 21:47:21 +0200")

Jan Nieuwenhuizen writes:

Hi Ludo'!

Replying to your initial review to notice the things that I initially
postponed and now have been done and the things that are still todo.

>> Previously we discussed that “-s i686-linux” on x86_64 would lead to a
>> different graph compared to a native i686-linux run.  Is it still the
>> case?  It looks like 80bd4a995 does the right thing in that respect.

I just push a fresh wip-bootstrap 6d975c901, and all differences between
native x86 and --system=i686-linux are now gone!

As discussed in bug-32749 I'm now using thunks for packages that use
package-with-explicit-inputs.  So, I reverted my previous `...leak'
commit rewrites.

Also, I changed more inputs to chunks (some ld-wrapper*) and I slightly
rewrote static-bash-for-glibc; just to make sure to look at
%current-system at run time, rather than load time.

>> I looked at the result and overall it LGTM!  So I think the next step is
>> to rebase the branch on ‘core-updates’ (or merge it) and rename it
>> ‘core-updates-next’.  WDYT?  Ricardo?

This new wip-bootstrap is rebased on core-updates, I think it's ready for a
rename to core-updates-next but wanted you all to have a look first.

>> Some comments on things that I think could be improved, in no particular
>> order:

>>   • There’s a couple of tests (for example in tests/debug-link.scm) that
>>     rely on %gcc-bootstrap, on the assumption that building it is
>>     cheap.  We should double-check that these are still okay on i686.

I haven't addressed this.

>>   • Could you add a couple of lines of explanation at the top of the new
>>     gnu/packages/patches/*.patch files, as we do for other patches?
>>     Some of them could also be simplified; for instance
>>     ‘glibc-boot-2.2.5.patch’ contains the diff of what looks like a
>>     leftover file.

I went through all patches, cleaned them up ad added comments.

Thanks!
janneke

  parent reply	other threads:[~2018-09-18 20:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 16:31 bootstrap: i686-linux now builds without binutils, gcc seeds Jan Nieuwenhuizen
2018-09-01 18:16 ` Gábor Boskovits
2018-09-02  5:21   ` Jan Nieuwenhuizen
2018-09-16 19:24 ` Ludovic Courtès
2018-09-17  6:10   ` Pjotr Prins
2018-09-17 18:29   ` Ricardo Wurmus
2018-09-17 19:25     ` Jan Nieuwenhuizen
2018-09-17 19:47   ` Jan Nieuwenhuizen
2018-09-17 21:55     ` Ricardo Wurmus
2018-09-18  8:27       ` Jan Nieuwenhuizen
2018-09-18  8:04     ` Vincent Legoll
2018-09-18  8:33       ` Jan Nieuwenhuizen
2018-09-18 20:53     ` Jan Nieuwenhuizen [this message]
2018-09-19  5:07       ` Jan Nieuwenhuizen
2018-09-19 18:07         ` Jan Nieuwenhuizen
2018-09-22 12:35           ` Ludovic Courtès
2018-09-22 15:34             ` Jan Nieuwenhuizen
2018-09-22 18:23               ` Jan Nieuwenhuizen
2018-09-23  8:02                 ` branched core-updates-next [WAS: Re: bootstrap: i686-linux now builds without binutils, gcc seeds] Jan Nieuwenhuizen
2018-09-23 16:09               ` bootstrap: i686-linux now builds without binutils, gcc seeds Joshua Branson
2018-09-23 16:29                 ` Jonathan Brielmaier
2018-09-22 12:23     ` Ludovic Courtès
2018-09-22 14:38       ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3by1qa4.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.