* [bug#32904] [PATCH] build-system/asdf: Properly handle dependency specification casing.
@ 2018-10-02 9:17 Andy Patterson
2018-10-02 12:06 ` bug#32904: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Andy Patterson @ 2018-10-02 9:17 UTC (permalink / raw)
To: 32904
From fd4047ab93f9be94ddfeef48248fca6a0580131f Mon Sep 17 00:00:00 2001
From: Andy Patterson <ajpatter@uwaterloo.ca>
Date: Tue, 2 Oct 2018 04:57:31 -0400
Subject: [PATCH] build-system/asdf: Properly handle dependency
specification casing.
* guix/build/lisp-utils.scm (normalize-dependency): Modify match
clauses to match the upper-case symbols that lisp produces.
---
guix/build/lisp-utils.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/guix/build/lisp-utils.scm b/guix/build/lisp-utils.scm
index 6470cfec9..3f5cdf86b 100644
--- a/guix/build/lisp-utils.scm
+++ b/guix/build/lisp-utils.scm
@@ -84,11 +84,12 @@
(define (normalize-dependency dependency)
"Normalize the name of DEPENDENCY. Handles dependency definitions
of the dependency-def form described by
-<https://common-lisp.net/project/asdf/asdf.html#The-defsystem-grammar>."
+<https://common-lisp.net/project/asdf/asdf.html#The-defsystem-grammar>.
+Assumes that any symbols in DEPENDENCY will be in upper-case."
(match dependency
- ((':version name rest ...)
+ ((':VERSION name rest ...)
`(:version ,(normalize-string name) ,@rest))
- ((':feature feature-specification dependency-specification)
+ ((':FEATURE feature-specification dependency-specification)
`(:feature
,feature-specification
,(normalize-dependency dependency-specification)))
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#32904: [PATCH] build-system/asdf: Properly handle dependency specification casing.
2018-10-02 9:17 [bug#32904] [PATCH] build-system/asdf: Properly handle dependency specification casing Andy Patterson
@ 2018-10-02 12:06 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-10-02 12:06 UTC (permalink / raw)
To: Andy Patterson; +Cc: 32904-done
Andy Patterson <ajpatter@uwaterloo.ca> skribis:
> From fd4047ab93f9be94ddfeef48248fca6a0580131f Mon Sep 17 00:00:00 2001
> From: Andy Patterson <ajpatter@uwaterloo.ca>
> Date: Tue, 2 Oct 2018 04:57:31 -0400
> Subject: [PATCH] build-system/asdf: Properly handle dependency
> specification casing.
>
> * guix/build/lisp-utils.scm (normalize-dependency): Modify match
> clauses to match the upper-case symbols that lisp produces.
Applied, thanks!
Ludo'.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-02 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-02 9:17 [bug#32904] [PATCH] build-system/asdf: Properly handle dependency specification casing Andy Patterson
2018-10-02 12:06 ` bug#32904: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.