all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#33173] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
@ 2018-10-27  8:30 Mathieu Othacehe
  2018-10-27  8:41 ` [bug#33172] " Mathieu Othacehe
  0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Othacehe @ 2018-10-27  8:30 UTC (permalink / raw)
  To: 33173

* gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
as a module.  It adds DRM support for BOCHS dispi vga interface used by
qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
"bochs-display" display device.
* gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.
---
 gnu/packages/aux-files/linux-libre/4.19-i686.conf   | 2 +-
 gnu/packages/aux-files/linux-libre/4.19-x86_64.conf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/aux-files/linux-libre/4.19-i686.conf b/gnu/packages/aux-files/linux-libre/4.19-i686.conf
index 07a035be9..c1df3f0f4 100644
--- a/gnu/packages/aux-files/linux-libre/4.19-i686.conf
+++ b/gnu/packages/aux-files/linux-libre/4.19-i686.conf
@@ -5949,7 +5949,7 @@ CONFIG_DRM_AST=m
 # CONFIG_DRM_MGAG200 is not set
 CONFIG_DRM_CIRRUS_QEMU=m
 CONFIG_DRM_QXL=m
-# CONFIG_DRM_BOCHS is not set
+CONFIG_DRM_BOCHS=m
 CONFIG_DRM_VIRTIO_GPU=m
 CONFIG_DRM_PANEL=y
 
diff --git a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
index 0e102c87d..a8f8c8164 100644
--- a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
@@ -5853,7 +5853,7 @@ CONFIG_DRM_AST=m
 # CONFIG_DRM_MGAG200 is not set
 CONFIG_DRM_CIRRUS_QEMU=m
 CONFIG_DRM_QXL=m
-# CONFIG_DRM_BOCHS is not set
+CONFIG_DRM_BOCHS=m
 CONFIG_DRM_VIRTIO_GPU=m
 CONFIG_DRM_PANEL=y
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
  2018-10-27  8:30 [bug#33173] [PATCH] gnu: linux-libre: Enable BOCHS DRM support Mathieu Othacehe
@ 2018-10-27  8:41 ` Mathieu Othacehe
  2018-10-27 21:18   ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Othacehe @ 2018-10-27  8:41 UTC (permalink / raw)
  To: 33172


Hi,

This article might help to understand what's new in QEMU 3.0 with VGA
emulation.

https://www.kraxel.org/blog/2018/10/qemu-vga-emulation-and-bochs-display/

Thanks,

Mathieu

Mathieu Othacehe writes:

> * gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
> as a module.  It adds DRM support for BOCHS dispi vga interface used by
> qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
> "bochs-display" display device.
> * gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.
> ---
>  gnu/packages/aux-files/linux-libre/4.19-i686.conf   | 2 +-
>  gnu/packages/aux-files/linux-libre/4.19-x86_64.conf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/aux-files/linux-libre/4.19-i686.conf b/gnu/packages/aux-files/linux-libre/4.19-i686.conf
> index 07a035be9..c1df3f0f4 100644
> --- a/gnu/packages/aux-files/linux-libre/4.19-i686.conf
> +++ b/gnu/packages/aux-files/linux-libre/4.19-i686.conf
> @@ -5949,7 +5949,7 @@ CONFIG_DRM_AST=m
>  # CONFIG_DRM_MGAG200 is not set
>  CONFIG_DRM_CIRRUS_QEMU=m
>  CONFIG_DRM_QXL=m
> -# CONFIG_DRM_BOCHS is not set
> +CONFIG_DRM_BOCHS=m
>  CONFIG_DRM_VIRTIO_GPU=m
>  CONFIG_DRM_PANEL=y
>  
> diff --git a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
> index 0e102c87d..a8f8c8164 100644
> --- a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
> +++ b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
> @@ -5853,7 +5853,7 @@ CONFIG_DRM_AST=m
>  # CONFIG_DRM_MGAG200 is not set
>  CONFIG_DRM_CIRRUS_QEMU=m
>  CONFIG_DRM_QXL=m
> -# CONFIG_DRM_BOCHS is not set
> +CONFIG_DRM_BOCHS=m
>  CONFIG_DRM_VIRTIO_GPU=m
>  CONFIG_DRM_PANEL=y

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
  2018-10-27  8:41 ` [bug#33172] " Mathieu Othacehe
@ 2018-10-27 21:18   ` Ludovic Courtès
  2018-10-28  1:58     ` Mathieu Othacehe
  2018-10-28  2:28     ` Mark H Weaver
  0 siblings, 2 replies; 6+ messages in thread
From: Ludovic Courtès @ 2018-10-27 21:18 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: Mark H Weaver, 33172

Hello Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> This article might help to understand what's new in QEMU 3.0 with VGA
> emulation.
>
> https://www.kraxel.org/blog/2018/10/qemu-vga-emulation-and-bochs-display/

Looks interesting.

>> * gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
>> as a module.  It adds DRM support for BOCHS dispi vga interface used by
>> qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
>> "bochs-display" display device.
>> * gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.

Perhaps we should enable it on AArch64 as well?  Mostly so that configs
don’t diverge too much.

Otherwise it LGTM.  Mark, WDYT?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
  2018-10-27 21:18   ` Ludovic Courtès
@ 2018-10-28  1:58     ` Mathieu Othacehe
  2018-10-28  2:28     ` Mark H Weaver
  1 sibling, 0 replies; 6+ messages in thread
From: Mathieu Othacehe @ 2018-10-28  1:58 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Mark H Weaver, 33172


Hi Ludo,

> Perhaps we should enable it on AArch64 as well?  Mostly so that configs
> don’t diverge too much.

It is already built as a module on our arm and arm64 configs. The arm
config was taken from Debian and not derived from GuixSD intel configs,
so it explains the divergence. I guess it is the same for the arm64
config.

Thanks,

Mathieu

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
  2018-10-27 21:18   ` Ludovic Courtès
  2018-10-28  1:58     ` Mathieu Othacehe
@ 2018-10-28  2:28     ` Mark H Weaver
  2018-10-28 11:59       ` Mathieu Othacehe
  1 sibling, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2018-10-28  2:28 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 33172

ludo@gnu.org (Ludovic Courtès) writes:

> Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>
>> This article might help to understand what's new in QEMU 3.0 with VGA
>> emulation.
>>
>> https://www.kraxel.org/blog/2018/10/qemu-vga-emulation-and-bochs-display/
>
> Looks interesting.
>
>>> * gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
>>> as a module.  It adds DRM support for BOCHS dispi vga interface used by
>>> qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
>>> "bochs-display" display device.
>>> * gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.

Looks good to me, please push.

> Perhaps we should enable it on AArch64 as well?  Mostly so that configs
> don’t diverge too much.

I just checked, and it's already enabled in our ARM and ARM64 configs.

FYI, our x86_64 and i686 configs were originally copied from
<https://jxself.org/git/kernel-configs.git>, and that's where the
decision to disable CONFIG_DRM_BOCHS originally came from.  In that
repo, you can see signs of indecision about whether to include that
module.  It was disabled in Jason's configs for 3.14-4.6, enabled in
4.7-4.15, disabled again in 4.16-4.18, and then enabled again in 4.19.

Since around 4.1 or 4.2, I've stopped looking at
<https://jxself.org/git/kernel-configs.git> and been using my own
judgement about new kernel configuration options brought to my attention
by "make oldconfig", but I haven't reviewed most of the older options.

Anyway, thanks for the patch!

       Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
  2018-10-28  2:28     ` Mark H Weaver
@ 2018-10-28 11:59       ` Mathieu Othacehe
  0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Othacehe @ 2018-10-28 11:59 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: 33172


Hi Mark,

> FYI, our x86_64 and i686 configs were originally copied from
> <https://jxself.org/git/kernel-configs.git>, and that's where the
> decision to disable CONFIG_DRM_BOCHS originally came from.  In that
> repo, you can see signs of indecision about whether to include that
> module.  It was disabled in Jason's configs for 3.14-4.6, enabled in
> 4.7-4.15, disabled again in 4.16-4.18, and then enabled again in 4.19.
>
> Since around 4.1 or 4.2, I've stopped looking at
> <https://jxself.org/git/kernel-configs.git> and been using my own
> judgement about new kernel configuration options brought to my attention
> by "make oldconfig", but I haven't reviewed most of the older options.
>
> Anyway, thanks for the patch!

Thank you for the explanation and the review! Pushed as
81f12f33b70855c0a99d5c2f1c2526e4a21b9823.

Mathieu

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-10-28 12:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-27  8:30 [bug#33173] [PATCH] gnu: linux-libre: Enable BOCHS DRM support Mathieu Othacehe
2018-10-27  8:41 ` [bug#33172] " Mathieu Othacehe
2018-10-27 21:18   ` Ludovic Courtès
2018-10-28  1:58     ` Mathieu Othacehe
2018-10-28  2:28     ` Mark H Weaver
2018-10-28 11:59       ` Mathieu Othacehe

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.