From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gTaCd-0005S3-5V
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:27:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gTaCc-000583-6Q
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:27:02 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54170)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gTaCc-00057x-3a
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:27:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gTaCb-0006i2-Vc
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:27:02 -0500
Subject: [bug#33540] [PATCH 2/3] gnu: Add lttoolbox.
Resent-Message-ID: <handler.33540.B33540.154378959125752@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20181130071612.6268-1-arunisaac@systemreboot.net>
	<20181130071612.6268-2-arunisaac@systemreboot.net>
Date: Sun, 02 Dec 2018 23:26:21 +0100
In-Reply-To: <20181130071612.6268-2-arunisaac@systemreboot.net> (Arun Isaac's
	message of "Fri, 30 Nov 2018 12:46:11 +0530")
Message-ID: <87y397k1ki.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33540@debbugs.gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/dictionaries.scm (lttoolbox): New variable.

[...]

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/apertium/lttoolbox/releases/download/v"
> +             version "/lttoolbox-" version ".tar.gz"))

Instead of relying on generated tarballs like this one whose content may
change over time, we=E2=80=99re now switching to using =E2=80=98git-fetch=
=E2=80=99.  Could you
change this one accordingly?

> +         (add-after 'unpack 'patch-autogen
> +           (lambda _
> +             (substitute* "autogen.sh"
> +               ((" && ./configure \"\\$@\"") ""))

Another option to deal with broken autogen.sh scripts is to remove
them.  :-)

> +    (synopsis "Lexical processing toolbox")
> +    (description "Lttoolbox is a toolbox for lexical processing, morphol=
ogical
> +analysis and generation of words.  Analysis is the process of splitting a
> +word (e.g. cats) into its lemma \"cat\" and the grammatical information
> +<n><pl>.  Generation is the opposite process.")

Maybe @code{<n><pl>}.

OK with these changes, thanks!

Ludo=E2=80=99.