From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/09: patches: honor NIX_STORE in site.py.
Date: Tue, 05 Feb 2019 00:14:01 +0100
Message-ID: <87y36vjgee.fsf@gnu.org>
References: <20190204192241.15758.66035@vcs0.savannah.gnu.org>
	<20190204192243.A58BA20B45@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:48773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gqnRU-0008Da-Dx
	for guix-devel@gnu.org; Mon, 04 Feb 2019 18:14:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gqnRN-0006RV-WD
	for guix-devel@gnu.org; Mon, 04 Feb 2019 18:14:18 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:53150)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1gqnRK-0006Nq-Tg
	for guix-devel@gnu.org; Mon, 04 Feb 2019 18:14:12 -0500
In-Reply-To: <20190204192243.A58BA20B45@vcs0.savannah.gnu.org> (guix-commits's
	message of "Mon, 4 Feb 2019 14:22:43 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Caleb Ristvedt <caleb.ristvedt@cune.org>

Hello reepca,

Since you mentioned on IRC that this commit is a candidate for =E2=80=98mas=
ter=E2=80=99,
I=E2=80=99m replying here.

Perhaps in the future you could email guix-patches@gnu.org for specific
commits like this one, especially when it=E2=80=99s not strictly related to=
 the
daemon?

guix-commits@gnu.org skribis:

> commit c44484dc2008f624788a228925e6cef2bdc6c917
> Author: Caleb Ristvedt <caleb.ristvedt@cune.org>
> Date:   Wed Jan 30 17:00:32 2019 -0600
>
>     patches: honor NIX_STORE in site.py.
>=20=20=20=20=20
>     Previously various python packages would fail to work unless the stor=
e they
>     were kept in was /gnu/store. This fixes that.
>=20=20=20=20=20
>     * gnu/packages/patches/python-2.7-site-prefixes.patch: Try NIX_STORE =
first
>       and only use /gnu/store as a fallback.

[...]

> --- a/configure.ac
> +++ b/configure.ac
> @@ -295,7 +295,8 @@ AC_CONFIG_FILES([Makefile
>                   po/guix/Makefile.in
>                   po/packages/Makefile.in
>                   etc/guix-daemon.cil
> -                 guix/config.scm])
> +                 guix/config.scm
> +		 gnu/packages/patches/python-2.7-site-prefixes.patch])

./configure does not generate any patch files based on patch templates,
and that=E2=80=99s on purpose.  Instead, when we need something like this, =
we
handle it the way ld-wrapper.in is handled: by doing the substitution
when creating the derivation.

In this case I=E2=80=99d suggest substituting @storedir@ in a post-unpack p=
hase.

Does that make sense?

Also, the summary line of the commit message should be something like:

  gnu: python@2.7: Honor NIX_STORE.

Last, the patch would need to go to =E2=80=98core-updates=E2=80=99 because =
of the number
of rebuilds it entails.

Could you send an updated version of the patch?

Thanks,
Ludo=E2=80=99.