From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1C2J-0000go-Ae for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1C29-0001Uc-PX for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:13 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1C24-0001KV-Ja for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1C24-0005pj-EK for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:04 -0500 Subject: [bug#34650] [PATCH 7/7] gnu: Add mailcatcher. Resent-Message-ID: References: <87ftsa24ts.fsf@ambrevar.xyz> <20190228174435.14499-1-mail@ambrevar.xyz> <20190228174435.14499-7-mail@ambrevar.xyz> <87fts2fgxe.fsf@cbaines.net> From: Pierre Neidhardt Message-ID: <87y35tvgav.fsf@ambrevar.xyz> In-reply-to: <87fts2fgxe.fsf@cbaines.net> Date: Tue, 05 Mar 2019 10:09:27 +0100 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 34650@debbugs.gnu.org Thanks for the review! > I'd recommend trying to avoid inserting packages at the end of modules, > or generally in the same place. This can make rebases difficult, and > increase the chances of conflicts when going to apply patches. I > generally try to fit patches in to modules somewhat alphabetically. You are very true here, but currently ruby.scm seems to follow no order whatsoever. Not sure where to insert the new packages then. -- Pierre Neidhardt https://ambrevar.xyz/