From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1yzr-0000EG-To for guix-patches@gnu.org; Thu, 07 Mar 2019 14:48:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1yzq-0008LA-RK for guix-patches@gnu.org; Thu, 07 Mar 2019 14:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50329) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1yzq-0008L5-LO for guix-patches@gnu.org; Thu, 07 Mar 2019 14:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1yzq-0001WE-I4 for guix-patches@gnu.org; Thu, 07 Mar 2019 14:48:02 -0500 Subject: [bug#34697] [PATCH] gnu: add r-lintr. Resent-Message-ID: References: <20190301080758.5548-1-anothersms@gmail.com> <20190301080758.5548-3-anothersms@gmail.com> From: Ricardo Wurmus In-reply-to: <20190301080758.5548-3-anothersms@gmail.com> Date: Thu, 07 Mar 2019 20:47:15 +0100 Message-ID: <87y35qtqkc.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Cc: 34697@debbugs.gnu.org Hi Nicol=C3=B2, thank you for this patch. Unfortunately, there are a couple of problems with the synopsis and the description. =E2=80=9C./pre-inst-env guix lint r-lintr=E2=80=9D will tell = you about some of the issues. For R packages in particular please make sure that single straight quotes as in =E2=80=9C'RStudio'=E2=80=9D are removed. Please also review the Contributing section in the Guix manual for information on what should appear in the commit message. Could you please send an updated patch as a reply to this message? Thanks! -- Ricardo